Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Unitful support #152

Closed
wants to merge 4 commits into from
Closed

Conversation

LebedevRI
Copy link

As noted in #151,
the functionality provided in utils.jl does not support Unitful Measuremets.

I'm not 100% sure about the unit handling in derivative.

I don't think uncertainty_components can properly support units,
since derivatives only track Measuremets, after stripping AbstractQuantity...

TODO: cov/cor/correlated_values.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #152 (3520aec) into master (c12fb10) will decrease coverage by 0.16%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 3520aec differs from pull request most recent head 10d7506. Consider uploading reports for the commit 10d7506 to get more accurate results

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   96.91%   96.76%   -0.16%     
==========================================
  Files           9        9              
  Lines         616      618       +2     
==========================================
+ Hits          597      598       +1     
- Misses         19       20       +1     
Files Changed Coverage Δ
src/utils.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant