fix world_age_at_entry in codegen #56700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The world is set (and reset) by the caller in toplevel code, so it should not be changed here as that makes the inference beforehand invalid. Also avoid allocating world_age_at_entry for every function, when it is almost never needed.
vtjnash
force-pushed
the
jn/codegen-world_age_at_entry
branch
from
7e0e8d7
to
7dcca44
Compare
gbaraldi
approved these changes
Nov 27, 2024
Keno
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The world is set (and reset) by the caller in toplevel code, so it should not be changed here as that makes the inference beforehand invalid (undermining the point of doing #56509 without any benefit). Also avoid allocating world_age_at_entry for every function, when it is almost never needed.