Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in behavior of extension loading in v1.11 #56426

Open
sethaxen opened this issue Nov 3, 2024 · 4 comments · Fixed by #56658
Open

Change in behavior of extension loading in v1.11 #56426

sethaxen opened this issue Nov 3, 2024 · 4 comments · Fixed by #56658

Comments

@sethaxen
Copy link
Contributor

sethaxen commented Nov 3, 2024

Suppose I have a package A with an extension that depends on packages B and C. Package B also depends on C. On Julia v1.10, if I loaded packages A and B, the extension would be loaded. But on Julia v1.11, it seems that I must also explicitly load package C for the extension to be loaded.

I created a repo demonstrating this change in behavior: https://github.com/sethaxen/ExtensionsTestDemo.jl, where A=ExtensionTestDemo, B=StatsBase, C=Random. The tests check whether the extension is loaded depending on which dependencies are loaded, and the CI (e.g. https://github.com/sethaxen/ExtensionsTestDemo.jl/actions/runs/11652519441) demonstrates the change in behavior between v1.10 and v1.11.

@IanButterworth
Copy link
Member

Duplicate of #56204 ?

@sethaxen
Copy link
Contributor Author

sethaxen commented Nov 3, 2024

Duplicate of #56204 ?

I'm not convinced it is. There the issue seems to be one extension trying to load another. That's not happening here.

@topolarity
Copy link
Member

I can reproduce this on 1.11 but it appears to be resolved on nightly

I have a hunch this was probably fixed by #56234 (which is marked for 1.11 backport but hasn't been done yet)

@topolarity
Copy link
Member

I can confirm this is fixed by #56658 (backport of the above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants