Added .sms to registry

[laurentbartholdi]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (93b8a70) to head (c15c9d0).
Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files          10       10           
  Lines         712      712           
=======================================
  Hits          653      653           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[laurentbartholdi]

Indeed it's not (yet) registered. I just submitted to the registrator, JuliaRegistries/General#97356

…

On Thu, 14 Dec 2023 at 18:35, Steve Kelly ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In src/registry.jl <#380 (comment)>: > @@ -531,3 +531,6 @@ add_format(format"QOI", "qoif", ".qoi", [:QOI => UUID("4b34888f-f399-49d4-9bb3-4 # Bibliography files. add_format(format"BIB", (), [".bib"], [:Bibliography => UUID("f1be7e48-bf82-45af-a471-ae754a193061")]) + +# sparse matrices +add_format(format"SMS", (), ".sms", [:Spasm => UUID("017bf598-072c-475c-a75e-c3e68736ce70")]) This doesn't appear to be a registered package? — Reply to this email directly, view it on GitHub <#380 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARAQUBYYYDTMRP7263WIITYJM2FFAVCNFSM6AAAAAA4T3ZUEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBSGMZTINJZGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Laurent Bartholdi laurent.bartholdi<at>gmail<dot>com Fachrichtung Informatik+Mathematik, Universität des Saarlandes Postfach 151150, 66041 Saarbrücken, Germany Tel. +49 681 3023227, Sekr. +49 681 3023430

[ViralBShah]

@laurentbartholdi Do you still want to merge this?

[laurentbartholdi]

Yes, I would very much like to. "Spasm" is pretty stable, though I'm fighting to set up an Yggdrasil build mechanism. Is there something special I should do?

…

On Sat, 12 Oct 2024 at 16:36, Viral B. Shah ***@***.***> wrote: @laurentbartholdi <https://github.com/laurentbartholdi> Do you still want to merge this? — Reply to this email directly, view it on GitHub <#380 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARAQUB5MSBDGMGULS3CEIDZ3EXWTAVCNFSM6AAAAABP2PAAVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGU4DMNRTGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Laurent Bartholdi laurent.bartholdi<at>gmail<dot>com Fachrichtung Informatik+Mathematik, Universität des Saarlandes Postfach 151150, 66041 Saarbrücken, Germany Tel. +49 681 3023227, Sekr. +49 681 3023430

[ViralBShah]

I think we need to get the tests running. But nothing otherwise.

[ViralBShah]

Is Spasm at least registered in General? The linked PR seems to be closed. I suppose we need to hold back until the package is registered.

[ViralBShah]

We need Documenter running (otherwise this won't appear in the docs).

[laurentbartholdi]

Uh, sorry @ViralBShah , but I tried to run locally the Documenter script, with no success (I thought it was through include("docs/make.jl") but that fails with a different error). I added a line in registry.md as I thought it should have been done. Do you know how to get it running? TIA!

[ViralBShah]

I think I was defeated by Documenter too, IIRC. It seems like it should be using the make.jl: https://github.com/JuliaIO/FileIO.jl/blob/master/.github/workflows/Documenter.yml

In any case, I suppose we can merge this PR, and fix docs separately. Perhaps @mortenpi may have a suggestion.

[mortenpi]

It seems like the docs/src/registry.md that actually get used in building the docs is auto-generated by https://github.com/JuliaIO/FileIO.jl/blob/master/docs/populate_registry.jl? It doesn't look like docs/registry.md is used for the docs. I think it's just generating bad-ish Markdown -- it looks like it's generating a [SpasM](nothing) link.

[laurentbartholdi]

@mortenpi yes indeed! I registered the SpaSM package, but it's not yet in the general registry (there's a waiting period of 3 days); and populate_registry.jl doesn't find it in the general registry, causing this error.

Let's wait a few more days to check everything works!

[laurentbartholdi]

@mortenpi OK, it seems that everything works, now that SpaSM has been officially registered! Is it ready to merge?