Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow docs/make.jl to be run from the root of the repo #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkNahabedian
Copy link

Add the repo root to LOAD_PATH so that docs/make.jl can be run from the repo root as well as from the docs directory.

…y from the docs directory

add the repo root to LOAD_PATH so that docs/make.jl can be run from the repo root as well as from the docs directory.
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (805bb7c) to head (c870211).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #465       +/-   ##
===========================================
- Coverage   94.33%   77.46%   -16.88%     
===========================================
  Files          24       24               
  Lines         742      741        -1     
===========================================
- Hits          700      574      -126     
- Misses         42      167      +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Collaborator

I am not sure about this.
It is one way to do it.
But it's not the only way.

I am much more used to doing ] dev.. and checking in the docs/Manifest.

Or not checking in the manifest and doing that just prior to building.

@gdalle
Copy link
Collaborator

gdalle commented Feb 24, 2024

Also this changes the global Julia state following docs build which is not ideal

@MarkNahabedian
Copy link
Author

My goal is that the current directory not affect the running of docs/make.jl.

I guess it might make more sense to do

cd(@__DIR__)

instead.

As for affecting global Julia state, my admittedly inelastic mind can't forsee a circumstance wehre make.jl is run from other than a stand-alone Julia session created solely for that purpose. Please enlighten me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants