Minor issues after introducing minMaxList are fixed. #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., idaholab#42.)
Issue 1. After 2nd iteration, objectives and constraint values are not matching with population. It was not due to wrong calculations of objectives and constraints. It was due to the misalignment of population and objectives as a dictionary.
Issue 2. When "max" is introduced, RAVEN first multiply a corresponding objective value with negative sign (i.e., -1). The new objective value (with minus sign) gives effect to constraint calculation. For instance, if a constraint says this objective needs to be smaller than 20, and the originally calculated objective value is 25. However, due to the -1 multiplication, it becomes -25 and suddenly it complies with a constraint.
What are the significant changes in functionality due to this change request?
This PR fixed the aforementioned issues.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.