Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSGA-II features Update on Optimizers/GeneticAlgorithm #12

Open
wants to merge 91 commits into
base: devel
Choose a base branch
from

Conversation

JunyungKim
Copy link


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., idaholab#42.)
  1. To give flexibility to users, soft constraint handling needs to be available in multi-objective optimization.
  2. Temporary Pareto-frontier plotting needs to be changed in order to drawing min-max / max-min / and max-max.
  3. All unit tests and regression tests are passed except one - This will be revisited shortly.
What are the significant changes in functionality due to this change request?
  1. fitness-based rank and crowding distance calculation is completed. Users can provide weights for each constraint to calculate a objective-specific fitness. Rank and CD will be calculated based on the fitness which reflect constraint violations.
  2. Pareto-frontier plotting reflecting optimization objectives - now commented.
  3. Some defects found as running SIMULATE3 were fixed.
  4. RAVEN Manual is updated.
  5. Regression tests for GeneticAlgorithm are passed.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

JunyungKim and others added 30 commits February 19, 2023 12:48
JunyungKim and others added 29 commits January 29, 2024 14:02
…regression tests are passed. simpleKnapsackTournament has differ, but final results were identical. It is regolded. Multi_MinwoReplacement is also regoldened.
…MinwoRepMultiObjective.xml is updated to have more then 2 intrinsic constraints.
…urvivorSelector is used for multi-objective optimization have been solved.
Method to Convert InputData.ParameterInput back to ElementTree XML node(s)
Note that it is only included in linux, so it should probably be
optional at best.
* Fixing latex errors.

\tau and \epsilon only allowed in math mode
Adding missing close $ and \end{itemize}

* Don't escape underscores followed by a {

They are likely in a math context and trying to do a subscript.

* Updating generated raven documentation.
…and logistics method should be revisited later for multi-objective problem.
@@ -41,8 +41,7 @@
from .crossOverOperators.crossovers import returnInstance as crossoversReturnInstance
from .mutators.mutators import returnInstance as mutatorsReturnInstance
from .survivorSelectors.survivorSelectors import returnInstance as survivorSelectionReturnInstance
from .survivorSelectors import survivorSelectors
from .survivorSelectors import survivorSelectors
from .survivorSelection import survivorSelection as survivorSelectionProcess
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have a folder called survivorSelectors and another called survivorSelection? Or did you mean to remove one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants