Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Themes #233

Open
yougotwill opened this issue Sep 6, 2024 · 2 comments
Open

macOS Themes #233

yougotwill opened this issue Sep 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@yougotwill
Copy link

yougotwill commented Sep 6, 2024

I have created light and dark themes that fit well on macOS. It would be awesome if they could be added as default themes if you are comfortable. 😊

Also you probably need to update the custom theme example in the README.md it is missing some of the options.

Dark Theme

{
  "primary": "FF0087B8",
  "primaryVariant": "FF0087B8",
  "onPrimary": "FFFFFFFF",
  "secondary": "FF3A3A3C",
  "onSecondary": "FFFFFFFF",
  "onBackground": "FFFFFFFF",
  "onBackgroundSecondary": "FF8E8E93",
  "error": "FFFF453A",
  "onError": "FFFFFFFF",
  "background": "FF262626",
  "backgroundSelected": "FF383838",
  "surface": "FF383838",
  "secondarySurface": "FF383838",
  "tertiarySurface": "FF383838",
  "addFile": "FF32D74B",
  "deletedFile": "FFFF453A",
  "modifiedFile": "FF59C8FA",
  "conflictingFile": "FFFFD60A",
  "dialogOverlay": "AA000000",
  "normalScrollbar": "FF3A3A3C",
  "hoverScrollbar": "FF505050",
  "diffLineAdded": "AA2ECC71",
  "diffLineRemoved": "AAE74C3C",
  "diffKeyword": "FF59C8FA",
  "diffAnnotation": "FFBABABA",
  "diffComment": "FF64E574",
  "isLight": false
}
macosDark-1 macosDark-2

Light Theme

Edit: I have just realised this is very close to the existing light theme so you might not want to include this one.

{
  "primary": "FF0087B8",
  "primaryVariant": "FF0087B8",
  "onPrimary": "FFFFFFFF",
  "secondary": "FFCCCCCC",
  "onSecondary": "FF000000",
  "onBackground": "FF000000",
  "onBackgroundSecondary": "FF4C4C4C",
  "error": "FFFF3B30",
  "onError": "FFFFFFFF",
  "background": "FFFFFFFF",
  "backgroundSelected": "FFEFEFF4",
  "surface": "FFFAFAFA",
  "secondarySurface": "FFEFEFF4",
  "tertiarySurface": "FFDADADA",
  "addFile": "FF32D74B",
  "deletedFile": "FFFF3B30",
  "modifiedFile": "FF59C8FA",
  "conflictingFile": "FFFFD60A",
  "dialogOverlay": "AAFFFFFF",
  "normalScrollbar": "FFB3B3B3",
  "hoverScrollbar": "FF9E9E9E",
  "diffLineAdded": "AA73DA84",
  "diffLineRemoved": "AAF28B82",
  "diffKeyword": "FF006DDB",
  "diffAnnotation": "FFBABABA",
  "diffComment": "FF64E574",
  "isLight": true
}
macosLight-1 macosLight-2
@yougotwill yougotwill added the enhancement New feature or request label Sep 6, 2024
@JetpackDuba
Copy link
Owner

Thank you for your suggestions. I have considered having a separate repo to have a compilation of themes at some point, so the themes would be welcome there (perhaps once I'm fully sure about the JSON format and it has stabilized).

I'm also not really sure about the contrast, the diff in both themes and the primary color in the dark theme seem to have some contrast issues. While it's not terrible, it's not great either. Both issues can be solved easily tho.

@yougotwill
Copy link
Author

No worries. Feel free to close this issue and I'll contribute the themes later when you have done the above 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants