Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store comments against a file #22

Open
amlwwalker opened this issue Apr 18, 2016 · 2 comments
Open

Store comments against a file #22

amlwwalker opened this issue Apr 18, 2016 · 2 comments

Comments

@amlwwalker
Copy link

I had a play with the commenting that is demonstrated in the leaps_share example. I wasn't sure but are these comments stored against a file permanently or is it just while a session exists? Its another thing I would be interested in working on if you had any ideas (and places within the code to look at) that you could share?

@Jeffail
Copy link
Owner

Jeffail commented Apr 19, 2016

Hey @amlwwalker, the messages sent while editing a document aren't stored. Leaps lets you broadcast text to all users on the same document, which are used for metadata such as cursor positions and these chat messages.

The logic for brokering document changes, messages etc is quite large now and needs breaking down, but it can be found at https://github.com/Jeffail/leaps/blob/master/lib/binder.go

@Jeffail
Copy link
Owner

Jeffail commented Apr 25, 2016

Hey @amlwwalker, just checking in since the refactor, the logic posted above is now at https://github.com/Jeffail/leaps/blob/master/lib/binder/binder.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants