Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular covers are not rounded in recents screen when staggered covers are enabled #1610

Open
8 of 9 tasks
realFPS opened this issue Aug 24, 2023 · 3 comments
Open
8 of 9 tasks
Labels
bug Something isn't working

Comments

@realFPS
Copy link

realFPS commented Aug 24, 2023

Steps to reproduce

  1. Enable staggered grid.
  2. Read a manga with irregular cover dimensions (square or rectangle).
  3. Open history.

Expected behavior

All covers should be rounded irrespective of their dimensions like they are rounded in Library.

Actual behavior

Enteries with cover having irregular dimensions are not rounded in the recents screen.

Crash logs

No response

TachiyomiJ2K version

1.6.6

Android version

Android 13

Device

OnePlus 9 pro

Other details

Library showing rounded covers for those enteries
IMG_20230824_185819

IMG_20230824_185846

Recents screen with those enteries
IMG_20230824_185944
IMG_20230824_185954
IMG_20230824_190028

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • If this is an issue with an extension, I should be opening an issue in the extensions repository.
  • I am reporting an issue exclusive to this fork. I have also checked that is not an issue on the main version of Tachiyomi
  • I have tried the troubleshooting guide.
  • I have updated the app to version 1.6.6.
  • I have updated all installed extensions.
  • I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
  • I have filled out all of the requested information in this form.
@realFPS realFPS added the bug Something isn't working label Aug 24, 2023
@realFPS
Copy link
Author

realFPS commented Sep 12, 2023

Another problem related to this, when show outline around covers is enabled, it shows the irregular covers like this (screenshots below) in the recents screen. Library is fine in both cases, it's just the recents screen which has these problems.

IMG_20230912_181021.jpg

IMG_20230912_181036.jpg

@Jays2Kings
Copy link
Owner

it's a known issue since forever but i'll leave it open to look into it one day

@realFPS
Copy link
Author

realFPS commented Sep 29, 2023

IMO the staggered grid could only be a library thing and recents can always follow uniform grid covers. Maybe its just me but uniform covers in recents looks better.

Staggered Uniform
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants