-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Report Payload #1365
Comments
@amadolid @marsninja @ChrisIsKing I came across this need for Einstein. Basically, we need to return a binary as the response for one of the walkers. I want to start a discussion here on what we think is the best way to support this. In Jaseci 1, I remember we support custom report status and payload but I am not sure if it was fully customizable. Perhaps we can start with jaseci 1 approach as a baseline and see if it is enough. @amadolid could you describe how the custom report work in jaseci 1 here? |
file -> custom -> normal we can have a report with typing similar to Jaseci 1
my only concern on this is, how can we make it more "define" as our behavior is technically a "array of entry/exit" What I mean by that is, Should we just based the response using
null return -> normal |
I just realized, why not just have multiple declaration of it will just overridden by the last declaration entry will be the very first trigger when walker is called while exit will very last trigger and will determine the actual return of the walker This can fix the custom report and binary return. We can discuss further on Monday |
@amadolid I am fine with the idea that the last |
To through my 2 cents in this, as long as the functionality of report can be defined in the plugin interface I'm ok with what you guys decide for jac-cloud. |
@ypkang Just to confirm, we decided to support this by introducing |
@ChrisIsKing that is correct. The behavior is:
FYI @amadolid |
Describe the feature you'd like
Examples
For example, to support something like this
The text was updated successfully, but these errors were encountered: