Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tm_player_market_values command: country/ies not found #398

Open
ucce87 opened this issue Sep 16, 2024 · 4 comments
Open

tm_player_market_values command: country/ies not found #398

ucce87 opened this issue Sep 16, 2024 · 4 comments

Comments

@ucce87
Copy link

ucce87 commented Sep 16, 2024

Hello,

I'm using the version 0.6.6.0000 of worldfootballr.
I have a similar issue to the one reported here. When I use the tm_player_market_values command, several countries don't work (e.g., Argentina, United States, Japan).

For example, when using:

JP1 <- tm_player_market_values(country_name = c("Japan"),start_year = 2024)

I get the following error:

Country Japan or season 2024 not found. Check that the country and season exists at https://github.com/JaseZiv/worldfootballR_data/blob/master/raw-data/transfermarkt_leagues/main_comp_seasons.csv

Alternatively, when I try:

JP1 <- tm_player_market_values(country_name = "", start_year = 2024, league_url = "https://www.transfermarkt.com/j1-league/startseite/wettbewerb/JAP1")

I encounter this error:

Error:
! Failed to evaluate glue component {league_urls}
Caused by error:
! object 'league_urls' not found
Run rlang::last_trace() to see where the error occurred.

Is there any way to resolve this issue?
A couple of weeks ago, I tried adding several league links to the CSV file mentioned in the error, but I'm not sure if helped.

Thank you so much!

@ucce87 ucce87 changed the title tm_player_market_values command: country non found tm_player_market_values command: country/ies not found Sep 16, 2024
@JaseZiv
Copy link
Owner

JaseZiv commented Sep 22, 2024

This is some strange behaviour on the Transfermarkt site... the data displayed at the URL for the 2024 season is the same as the data for the 2023 season:

2024 Season:
https://www.transfermarkt.com/j1-league/startseite/wettbewerb/JAP1/plus/?saison_id=2024:
image

2023 Season:
https://www.transfermarkt.com/j1-league/startseite/wettbewerb/JAP1/plus/?saison_id=2023
image

Will close this issue and once the J-League gets into their current season, I'm sure this will rectify itself

@ucce87
Copy link
Author

ucce87 commented Sep 23, 2024

Hi JazeViz!
I probably chose the worst example. I have the same issue with almost all of the American competitions (e.g., Argentina, Brazil, Colombia, United States,...).

@ucce87
Copy link
Author

ucce87 commented Nov 4, 2024

Can I contribute in any way to help fix this issue?
I am not sure if the problem is specifically related to missing links in this csv file.

e.g.,

"MLS","Americas","United States","https://www.transfermarkt.com/major-league-soccer/startseite/wettbewerb/MLS1","2023","https://www.transfermarkt.com/major-league-soccer/startseite/wettbewerb/MLS1/plus/?saison_id=2023"

or

"Liga FUTVE Apertura","Americas","Venezuela","https://www.transfermarkt.com/liga-futve-apertura/startseite/wettbewerb/VZ1A","2023","https://www.transfermarkt.com/liga-futve-apertura/startseite/wettbewerb/VZ1A/plus/?saison_id=2023").

Thank you!

@JaseZiv
Copy link
Owner

JaseZiv commented Nov 6, 2024

Can I contribute in any way to help fix this issue? I am not sure if the problem is specifically related to missing links in this csv file.

e.g.,

"MLS","Americas","United States","https://www.transfermarkt.com/major-league-soccer/startseite/wettbewerb/MLS1","2023","https://www.transfermarkt.com/major-league-soccer/startseite/wettbewerb/MLS1/plus/?saison_id=2023"

or

"Liga FUTVE Apertura","Americas","Venezuela","https://www.transfermarkt.com/liga-futve-apertura/startseite/wettbewerb/VZ1A","2023","https://www.transfermarkt.com/liga-futve-apertura/startseite/wettbewerb/VZ1A/plus/?saison_id=2023").

Thank you!

Hey there,

More than happy for you to have a go at building a solution. Feel free to create a PR on either this repo, or the worldfootballR_data repo (depending on how you attempt this fix).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants