Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build dictionary mappings #14

Open
JaseZiv opened this issue Feb 12, 2021 · 7 comments
Open

Build dictionary mappings #14

JaseZiv opened this issue Feb 12, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@JaseZiv
Copy link
Owner

JaseZiv commented Feb 12, 2021

Create a function (or set of functions) to be able to map league, team, player names from fbref.com and transfermarkt.com data

@JaseZiv JaseZiv added the enhancement New feature or request label Feb 12, 2021
@olivermueller
Copy link

that would be super useful!

@JaseZiv
Copy link
Owner Author

JaseZiv commented Sep 14, 2021

Players for the big five Euro leagues have now been mapped.

Can be accessed using player_dictionary_mapping() of at this URL

@bfooty
Copy link

bfooty commented Jul 9, 2022

Hi there; I have a large list of transfermkt player names but no URL's;. Any idea how to map via names, or get transfermkt player URL's from their names?

@JaseZiv
Copy link
Owner Author

JaseZiv commented Jul 9, 2022

Nice one @bfooty!

For which leagues do you mean?

@Paulj1989
Copy link

I'm looking to use data on team points totals (taken either from fb_season_team_stats() or tm_matchday_table()) and squad market values (tm_player_market_values()) and transfer spending (tm_team_transfer_balances). Having done some initial wrangling, I've realised that the team names often don't match up and that makes merging the different datasets a little tricky.

After a quick conversation with @JaseZiv on Twitter, I thought I could have a crack at the mapping function for team names, starting with a team name dictionary as a reference point. Do you guys have any suggestions on how the team mapping function might need to be structured?

@JaseZiv
Copy link
Owner Author

JaseZiv commented Aug 24, 2022

I'm looking to use data on team points totals (taken either from fb_season_team_stats() or tm_matchday_table()) and squad market values (tm_player_market_values()) and transfer spending (tm_team_transfer_balances). Having done some initial wrangling, I've realised that the team names often don't match up and that makes merging the different datasets a little tricky.

After a quick conversation with @JaseZiv on Twitter, I thought I could have a crack at the mapping function for team names, starting with a team name dictionary as a reference point. Do you guys have any suggestions on how the team mapping function might need to be structured?

Awesome @Paulj1989! Looking forward to seeing what you come up with.

For reference, you can have a look at how I put together the mapping for players here.

Then, here is the function in worldfootballR to call the data frame.

Let me know if you ever want to discuss/get help/ bounce ideas off.

Jase

@Paulj1989
Copy link

Thanks for this Jase. I'm not 100% sure when I'll get a chance to work on this properly, but my initial concern/issue is working out how I'd structure this in comparison to the player mapping you've put together.

The differences between club names within Transfermarkt seems as big an issue as between Transfermarkt and FB Ref, and that seems like an extra layer of complexity on top of everything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants