Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using via webpack #200

Open
anero opened this issue Jun 25, 2018 · 1 comment
Open

Add support for using via webpack #200

anero opened this issue Jun 25, 2018 · 1 comment

Comments

@anero
Copy link

anero commented Jun 25, 2018

Hello,

Would it be possible to add support for using JS code via webpack?
We started doing some of this work, adding a package.json file and modularizing jquery.remotipart.js and jquery.iframe-transport.js, but haven't been able to figure out how to include the iframe transport code into remotipart in a way that works both, with webpacker (i.e.: import {} from './jquery.iframe-transport.js') and assets pipeline (i.e.: //= require jquery.iframe-transport.js).

We've limited experience with JS modularizing so if anyone else has pointers on patterns for this use case, would be glad to wrap the work and submit a PR.

Thanks!

@anero
Copy link
Author

anero commented Jun 26, 2018

Update on this: we've just submitted a PR with changes for supporting usage via webpack - #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant