Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong bool properties cast to redis #48

Open
mix359 opened this issue May 19, 2019 · 0 comments
Open

Wrong bool properties cast to redis #48

mix359 opened this issue May 19, 2019 · 0 comments

Comments

@mix359
Copy link

mix359 commented May 19, 2019

Hi,
I've started playing with this software today, and first of all, thanks for your work!

I'm interested in creating a multicast link to stream the same audio on many buildings of the school I work.
Trying the package I was having a continues "CRITICAL - No data received for 3 seconds!" message so I've red all the code and found that the multicast selection is not set correctly on the receiver.

In particular, in the LinkConfig object the multicast (and all the bool value) is set as a int on redis (line 54), read back as a string and compared with the string 'True', that could never work.
So I've changed the line 54 to
value = ('True' if value else 'False')
and now it work.

Hope this can help.
Let me know if you need the PR with the modification or you can integrate it directly ;)
Cheers Mix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant