We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The comment states that:
* @param handled Predicate invoked each occurrence to determine the return value of the * underlying [TextView.OnEditorActionListener].
But the code seems to use the handler predicate to filter the events and always returns true when the event is sent to the observer:
handler
true
try { if (!isDisposed && handled(actionId)) { observer.onNext(actionId) return true } } catch (e: Exception) { observer.onError(e) dispose() } return false
Perhaps two predicates? One for the filtering and one for the return value.
Or at least a fix for the comment.
The same issue is found in TextView.editorActionEvents.
TextView.editorActionEvents
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The comment states that:
But the code seems to use the
handler
predicate to filter the events and always returnstrue
when the event is sent to the observer:Perhaps two predicates? One for the filtering and one for the return value.
Or at least a fix for the comment.
The same issue is found in
TextView.editorActionEvents
.The text was updated successfully, but these errors were encountered: