Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unecessary msilib import #332

Closed
gmelodie opened this issue Feb 19, 2024 · 2 comments · Fixed by #333
Closed

Unecessary msilib import #332

gmelodie opened this issue Feb 19, 2024 · 2 comments · Fixed by #333
Assignees
Labels
bug Something isn't working

Comments

@gmelodie
Copy link
Contributor

While building the project locally for development I found that commenting out this line from pydoro_tui.py made pydoro work on Linux, while before it was giving me:

(venv) ➜  pydoro git:(master) pydoro
Traceback (most recent call last):
  File "/home/gmelodie/.local/bin/pydoro", line 33, in <module>
    sys.exit(load_entry_point('pydoro', 'console_scripts', 'pydoro')())
  File "/home/gmelodie/.local/bin/pydoro", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 171, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/gmelodie/repos/pydoro/pydoro/pydoro_tui.py", line 7, in <module>
    from msilib.schema import EventMapping
ModuleNotFoundError: No module named 'msilib'

I noticed that nothing is using EventMapping. Maybe we'd want to comment it out?

@gmelodie gmelodie added the bug Something isn't working label Feb 19, 2024
@JaDogg
Copy link
Owner

JaDogg commented Feb 19, 2024

Actually there seem to be few more unwanted imports there hmm

@JaDogg
Copy link
Owner

JaDogg commented Feb 19, 2024

Got rid of, seems like I missed this in a review and someone accidently added some imports. @gmelodie thanks for catching it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants