Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - SA2 scenario is slightly overconservative #321

Open
dodu94 opened this issue Oct 4, 2024 · 2 comments
Open

[BUG] - SA2 scenario is slightly overconservative #321

dodu94 opened this issue Oct 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dodu94
Copy link
Member

dodu94 commented Oct 4, 2024

Describe the bug
The irradiation scenario (SA2) used in the D1S assessment to compute irradiation factors is not entirely correct (conservative)

Expected behavior
Either this is corrected or the inconsistency needs to be mentioned in the documentation

@dodu94
Copy link
Member Author

dodu94 commented Oct 31, 2024

I am more in favor of mentioning this in the documentation to avoid re-running all previous calculations, @Radiation-Transport @alexvalentine94 any thought on this?

@alexvalentine94
Copy link
Collaborator

Agreed - for the scope of what is trying to be achieved here I think this is acceptable. The important point is that the same scenario is being used for all the simulations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants