Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Improve style in miscellaneous tests #4203

Commits on Sep 4, 2023

  1. STYLE: Increase consistency in test argument check message

    Increase consistency in the missing argument check message, following
    the ITK SW guide coding guidelines. Specifically, make the error message
    be consistent.
    jhlegarreta committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    c268876 View commit details
    Browse the repository at this point in the history
  2. STYLE: Conform to ITK style guidelines in test ending message

    Conform to ITK style guidelines in test ending message: add it where
    missing and modify it where existing to match the ITK SWG module to
    increase consistency.
    jhlegarreta committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    dfc9fcd View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. STYLE: Prefer using constexpr <type> over struct for image dimension

    Prefer declaring image dimensions as `constexpr <type>` over `struct` in
    tests: a struct does not provide any particular advantage to host the
    image dimensions.
    
    Declare the type as an `unsigned int` and change the loop index
    variables accordingly to avoid signed/unsiged comparison mismatch
    warnings. Take advantage of the commit to limit the loop index
    variables' scope to the loop.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    eaf25ef View commit details
    Browse the repository at this point in the history
  2. STYLE: Conform to ITK comment style for within-code comments (tests)

    Conform to ITK comment style for within code comments in tests: prefer
    double forward slashes for within code comment blocks, and place the
    comment blocks preferably immediately before the statemet they refer to.
    
    Take advantage of the commit to use sentence cases in miscellaneous
    comments.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    488ac83 View commit details
    Browse the repository at this point in the history
  3. STYLE: Remove empty comment lines in tests

    Remove unnecessary and uninformative single-comment and empty comment
    lines in tests.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e4643c5 View commit details
    Browse the repository at this point in the history
  4. STYLE: Remove uninformative standard output message in itkHistogramTest

    Remove uninformative standard output message in `itkHistogramTest.cxx`.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    41ad697 View commit details
    Browse the repository at this point in the history
  5. STYLE: Remove uninformative comments in tests

    Remove uninformative comments in tests.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b9b530f View commit details
    Browse the repository at this point in the history
  6. STYLE: Do not allow lonely std output endl statements in misc tests

    Do not allow lonely `std::cout << std::endl` statements in miscellaneous
    tests: move them to the preceding standard output message printing
    statment.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f9f3078 View commit details
    Browse the repository at this point in the history
  7. STYLE: Increase consistency in newline character use in tests

    Increase consistency in newline character use in tests: use `std::endl`
    instead of `\n` to introduce new lines.
    
    Remove `\n` characters in excess in miscellaneous output stream
    messages.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    154938d View commit details
    Browse the repository at this point in the history
  8. STYLE: Remove blank lines in excess in miscellaneous tests

    Remove blank lines in excess in miscellaneous tests.
    jhlegarreta committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    603b67d View commit details
    Browse the repository at this point in the history