-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: Improve style in miscellaneous tests #4203
STYLE: Improve style in miscellaneous tests #4203
Commits on Sep 4, 2023
-
STYLE: Increase consistency in test argument check message
Increase consistency in the missing argument check message, following the ITK SW guide coding guidelines. Specifically, make the error message be consistent.
Configuration menu - View commit details
-
Copy full SHA for c268876 - Browse repository at this point
Copy the full SHA c268876View commit details -
STYLE: Conform to ITK style guidelines in test ending message
Conform to ITK style guidelines in test ending message: add it where missing and modify it where existing to match the ITK SWG module to increase consistency.
Configuration menu - View commit details
-
Copy full SHA for dfc9fcd - Browse repository at this point
Copy the full SHA dfc9fcdView commit details
Commits on Sep 5, 2023
-
STYLE: Prefer using
constexpr <type>
overstruct
for image dimensionPrefer declaring image dimensions as `constexpr <type>` over `struct` in tests: a struct does not provide any particular advantage to host the image dimensions. Declare the type as an `unsigned int` and change the loop index variables accordingly to avoid signed/unsiged comparison mismatch warnings. Take advantage of the commit to limit the loop index variables' scope to the loop.
Configuration menu - View commit details
-
Copy full SHA for eaf25ef - Browse repository at this point
Copy the full SHA eaf25efView commit details -
STYLE: Conform to ITK comment style for within-code comments (tests)
Conform to ITK comment style for within code comments in tests: prefer double forward slashes for within code comment blocks, and place the comment blocks preferably immediately before the statemet they refer to. Take advantage of the commit to use sentence cases in miscellaneous comments.
Configuration menu - View commit details
-
Copy full SHA for 488ac83 - Browse repository at this point
Copy the full SHA 488ac83View commit details -
STYLE: Remove empty comment lines in tests
Remove unnecessary and uninformative single-comment and empty comment lines in tests.
Configuration menu - View commit details
-
Copy full SHA for e4643c5 - Browse repository at this point
Copy the full SHA e4643c5View commit details -
STYLE: Remove uninformative standard output message in itkHistogramTest
Remove uninformative standard output message in `itkHistogramTest.cxx`.
Configuration menu - View commit details
-
Copy full SHA for 41ad697 - Browse repository at this point
Copy the full SHA 41ad697View commit details -
STYLE: Remove uninformative comments in tests
Remove uninformative comments in tests.
Configuration menu - View commit details
-
Copy full SHA for b9b530f - Browse repository at this point
Copy the full SHA b9b530fView commit details -
STYLE: Do not allow lonely std output endl statements in misc tests
Do not allow lonely `std::cout << std::endl` statements in miscellaneous tests: move them to the preceding standard output message printing statment.
Configuration menu - View commit details
-
Copy full SHA for f9f3078 - Browse repository at this point
Copy the full SHA f9f3078View commit details -
STYLE: Increase consistency in newline character use in tests
Increase consistency in newline character use in tests: use `std::endl` instead of `\n` to introduce new lines. Remove `\n` characters in excess in miscellaneous output stream messages.
Configuration menu - View commit details
-
Copy full SHA for 154938d - Browse repository at this point
Copy the full SHA 154938dView commit details -
STYLE: Remove blank lines in excess in miscellaneous tests
Remove blank lines in excess in miscellaneous tests.
Configuration menu - View commit details
-
Copy full SHA for 603b67d - Browse repository at this point
Copy the full SHA 603b67dView commit details