-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic CLI support for windows OS #94
Comments
Hi👋 thanks for creating your first issue for IOSF, Will get back to you soon !. |
This dependency has been caused because of the |
One can surely use WSL but that would make Dynamic CLI restrictive and available only for users who are on Unix OS. I think we should try to be more inclusive and find alternatives that support all users regardless of their OS 😄 |
Yes @guptaaastha, the cli is not supporting windows right now due to the |
We can use |
Hmm yeah |
I think we can do specific change only for windows env. So that other would not face UX issues. |
Or else we need to find out some other way to support all the environment equally and efficiently. |
I think this is what we have to do |
I'll do a research and find any alternative. You guy's can also search, If you find anything do let me know here. |
This is quite useful. You guys can also take a look. 2-3 people gave suggestions regarding the same problem that we are facing - bchao1/bullet#2 |
But, they don't have a solution for that 🙁 |
They have but that was specific to windows only. Still searching for some other alternative |
Let's be on the lookout for solutions |
@pranavbaburaj i think you wrote wrong. It's not support for windows and by mistake you wrote it only supports for windows |
I just noticed this too, @pranavbaburaj please correct it. |
I have updated it, Thank you 🙂 |
We can use this as a backup option for windows- https://github.com/aegirhall/console-menu |
Hmm, but we will have to rewrite it entirely or reimplement it for windows 🤔 |
Fow now should we only integrated it when OS is windows ? |
Yeah, We first check if the platform is windows, then create this interface for windows |
@pranavbaburaj Yes, This can be done but this would be temp. We have to migrate the whole things to something else |
There is a workaround to make it work on window
That is we can check if the current os the user is on is windows or not if we found its windows import msvcrt and replace the same functionalities which are done using terminos . @GouravSardana @pranavbaburaj this solution should work and looks like the only workaround rn. Moreover the dependency due to which the error occurs i.e simple-term-menu this can be referred. |
Currently Dynamic CLI has a dependency on the
termios
module. This module does not support windows OS (refer the links provided below for reference). This issue is to point attention towards this drawback and open up a conversation whether this is something that can be addressed.Please refer:
https://docs.python.org/3/library/tty.html
https://docs.python.org/3/library/termios.html#module-termios
The text was updated successfully, but these errors were encountered: