Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from argparse to Typer #183

Open
pybash1 opened this issue Apr 6, 2022 · 6 comments
Open

Switch from argparse to Typer #183

pybash1 opened this issue Apr 6, 2022 · 6 comments

Comments

@pybash1
Copy link

pybash1 commented Apr 6, 2022

🚀 Feature

Use Typer instead of argparse

Have you read the Contributing Guidelines on Pull Requests?

Yes

Motivation

I have made applications using both Typer and argparse, and the developer and user experience with Typer is far better in my opinion.

Pitch

This feature reduces a lot of code and also uses modern features like decorators for sub-command handlers, etc. It is cross platform. It will reduce code complexity, allowing new and beginner programmers to contribute.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Hi👋 thanks for creating your first issue for IOSF, Will get back to you soon !.

@GouravSardana
Copy link
Member

@pybash1 Thanks for your wonderful advice. Can you show me some of the packages which uses this thing ?
we need more clarity before moving to any parser.
cc @pranavbaburaj @PradyumnaKrishna @peb-peb

@pybash1
Copy link
Author

pybash1 commented Apr 7, 2022

@GouravSardana It's hard for me to remember an example right now, but if I can remember any, I will let you know.

@peb-peb
Copy link

peb-peb commented Apr 8, 2022

I played around with Typer and it's a wonderful tool, but refactoring and moving from argparse to Typer is a negative from my side. Because even if we refactor the code, it would not change anything major and add to the dependency of the project.

Typer does bring a method for autocompletion in the terminal itself, but it's not the kind of autocomplete that we're looking for (we're looking for the TAB completion style of autocompletion).

But, in it's defense, I would say that it's really beginner-friendly, easy to implement, and has many awesome features.

@GouravSardana @pranavbaburaj what's your opinion on this?

@lainq
Copy link
Contributor

lainq commented Apr 8, 2022

I would be totally fine with porting to typer, if everyone's happy with the decision.

@GouravSardana
Copy link
Member

We're not in favour of moving from argparser to Typer.

cc @pranavbaburaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants