Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status not shown with certain configurations #454

Open
vercas opened this issue Oct 7, 2023 · 2 comments · May be fixed by #500
Open

Status not shown with certain configurations #454

vercas opened this issue Oct 7, 2023 · 2 comments · May be fixed by #500
Labels
❓ question This issue is a question

Comments

@vercas
Copy link

vercas commented Oct 7, 2023

Describe the bug

The status of the last command isn't shown on the right prompt with the configuration below.
My fish_variables file contains this though:

SETUVAR _tide_right_items:status\x1ecmd_duration\x1econtext\x1ejobs\x1epython\x1etime

Steps to reproduce

Set configuration as such:

tide configure --auto --style=Classic --prompt_colors='True color' --classic_prompt_color=Dark --show_time='24-hour format' --classic_prompt_separators=Slanted --powerline_prompt_heads=Slanted --powerline_prompt_tails=Flat --powerline_prompt_style='Two lines, character' --prompt_connection=Dotted --powerline_right_prompt_frame=No --prompt_connection_andor_frame_color=Dark --prompt_spacing=Compact --icons='Many icons' --transient=No

Then run a command like false.

Screenshots

With the configuration above, status is not showing:
Screenshot 2023-10-07 at 12 40 17

With the configuration below, status is working:
Screenshot 2023-10-07 at 12 39 38

Environment

Output of tide bug-report: 

fish version: 3.6.1
tide version: 6.0.1
term: screen-256color
os: Ubuntu 22.04
terminal emulator: tmux
fish startup: 8.40 millis
fisher plugins: jorgebucaran/fisher ilancosman/tide@v6

Additional context

Works with this configuration:

tide configure --auto --style=Rainbow --prompt_colors='True color' --show_time='24-hour format' --rainbow_prompt_separators=Angled --powerline_prompt_heads=Sharp --powerline_prompt_tails=Flat --powerline_prompt_style='One line' --prompt_spacing=Compact --icons='Many icons' --transient=No
@vercas vercas added the 🐛 bug Something isn't working label Oct 7, 2023
@IlanCosman
Copy link
Owner

Not a bug, but maybe a behavior that should be changed. For simple statuses, (e.g. false), the character item already shows the status by changing color, so there's no need for the status item to show up.

@IlanCosman IlanCosman added ❓ question This issue is a question and removed 🐛 bug Something isn't working labels Oct 8, 2023
@vercas
Copy link
Author

vercas commented Oct 8, 2023 •
edited
Loading

Ooooh I see it now. I didn't notice it before because I'm colorblind.
If I do getopt -T then I see a status of 4 on the right prompt, so I guess it's all working as intended.
I just didn't know it was designed like this.

@chapa chapa linked a pull request Apr 1, 2024 that will close this issue
Open
4 tasks
@primeapple primeapple mentioned this issue Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
❓ question This issue is a question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(status): add tide_status_display chapa/tide
2 participants
@vercas @IlanCosman