Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTETC: allow inverting the value passed to BUMP_STOPS, load in cmd file in twincat ioc #6976

Closed
2 tasks
rerpha opened this issue Jan 18, 2022 · 2 comments
Closed
2 tasks
Labels

Comments

@rerpha
Copy link
Contributor

rerpha commented Jan 18, 2022

As someone who uses a Beckhoff I would like my bump strips signal to be correctly propagated to IBEX.

Firstly, these aren't loaded in from twincat, but are from galil, so we should load them in from both (and assume only one will be used)
Secondly, when testing on LARMOR, the signals are the wrong way round, as in tripped is 0 and not tripped is 1, rather than changing this motion logic I want to be able to invert the value and send it to MOT:BUMP_STOPS

Acceptance Criteria

What is the acceptance criteria?

  • INSTETC is changed to load in bumpstop.cmd from twincat\ as well as galil\
  • a way of inverting the value send to MOT:BUMP_STOPS is given, through a calcout or similar

Extra Information

This could be done with a macro in the same way that the PV name is passed to INSTETC via bumpstops.cmd.

A workaround will be added in custom_records.db on LARMOR for now so that should be removed when this is deployed - this will be done in #6966

@rerpha rerpha changed the title Bumpstrips: allow inverting the value passed to INSTETC Bumpstrips: allow inverting the value passed to INSTETC, load in cmd file in beckhoff ioc Jan 18, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Jan 18, 2022

in case we need to patch this on instruments I have made ISISComputingGroup/EPICS-ioc#668 for the first point of the acceptance criteria

@rerpha rerpha changed the title Bumpstrips: allow inverting the value passed to INSTETC, load in cmd file in beckhoff ioc INSTETC: allow inverting the value passed to BUMP_STOPS, load in cmd file in twincat ioc Jan 18, 2022
@rerpha rerpha added the 2 label Jan 18, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Mar 16, 2023

no longer really an issue as we can quite easily just flip this PV in motorextensions loaded in by TC

@rerpha rerpha closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants