-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore/fix support for Qt4 #665
Labels
Comments
barracuda156
referenced
this issue
Oct 3, 2023
- Code is now clazy clean with CLAZY_CHECKS="no-connect-by-name,no-overloaded-signal" - Given the minimum Qt version is 5.10, remove ifdef's for older versions - Some more range based for and related cleanups. - Some include cleanups
12 tasks
So there were two pointes which has broken
|
I have found why it was broken. There was a bunch of “improvements” leading to:
This is Qt5-only syntax: https://forum.qt.io/topic/66593/error-q_decl_override-does-not-name-a-type Breaking commits: Will see if fixing these will fix the build. |
UPD. This does not work too: e0964b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While source code implies a possibility of building with Qt4
QtPass/qtpass.pri
Line 13 in ab5c1e9
QtPass
back to v. 1.2.3, and it kept failing with similar errors.Could support for Qt4 be restored? (If it was removed in an organized way, I can revert needed commits and make a PR. Presently I have no idea whether it was done in some coherent way or in random commits.)
The text was updated successfully, but these errors were encountered: