Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARTIn Chip #7

Merged
merged 13 commits into from
Nov 22, 2024
Merged

MARTIn Chip #7

merged 13 commits into from
Nov 22, 2024

Conversation

nickguimara
Copy link
Contributor

@nickguimara nickguimara commented Nov 8, 2024

A chip developed at the University of São Paulo (USP) aimed at testing a median finding algorithm that should be encompassed in a front end readout ASIC for particle physics experiments.

Contact via: [email protected]

Signed-off-by: nickguimara <[email protected]>
Signed-off-by: nickguimara <[email protected]>
Signed-off-by: nickguimara <[email protected]>
Signed-off-by: nickguimara <[email protected]>
@nickguimara
Copy link
Contributor Author

KrzysztofHerman filling script was used to remove DRC errors

@nickguimara
Copy link
Contributor Author

The DRC check in this pull requested has dissapeared, is that expected?

@KrzysztofHerman
Copy link
Contributor

@nickguimara thank you for the submission, your design is DRC clean (minimal set).
after a short review please fix the following:

  1. Please provide your behavioral System Verilog, Verilog which was used for synthesis. The same applies to the configuration of the OpenORAD flow scripts and sv2v. Since our IHP-Open-PDK project has an educational purpose the general idea is that one should be able to replicate your design having data from this repository, documentation and valid version of the tools and the PDK.
  2. gds names - please provide something more verbose and meaningful like MARTIn_nofill.gds
  3. gds names - the final, filled version of the gds should start with the prefix FMD_QNC_
  4. gds top level cell name - please provide some other name ie. MARTIn_TOP
  5. fix other file names also
  6. provide information which version/branch of the PDK and tools (OpenRoad, KLayout etc.) were used (the best is to provide a particular branch/commit)
  7. Provide information about pad ring in the documentation (pinout).
  8. Provide a block diagram which includes functional blocks implemented in System Verilog.

Signed-off-by: nickguimara <[email protected]>
@nickguimara
Copy link
Contributor Author

Added (1) to (7) corrections. 3 minimal DRC erros are expected, but are outside the chip area. The block diagram is being made

Signed-off-by: nickguimara <[email protected]>
@nickguimara
Copy link
Contributor Author

Block diagram added, everything should be right now. If you find out any modifications necessary, please let me know.

@KrzysztofHerman
Copy link
Contributor

@nickguimara reviewing your last commit still I can not reproduce the design.

  1. How one is supposed to tun the testbenches using SystemVerilog files, which open source tool supports it ?
  2. In the config.mk there are no references to the IO pads and bondpad. So the question is how the physical design was performed using this script.

Please update the repository with the data and configuration necessary to reproduce your design.

@nickguimara
Copy link
Contributor Author

nickguimara commented Nov 19, 2024

The IO pads and bond pad configuration are configured trough the pad.tcl file. That file is called through the config.mk file. Do you want me to further clarify that in the specifications? Thought is was common procedure in OpenRoad environment

@nickguimara
Copy link
Contributor Author

And I'll provide the correct Verilog testbenches

@KrzysztofHerman
Copy link
Contributor

@nickguimara
Congratulations !
You design was accepted for production.
Testfield: T576
Top cell name: martin_top

@KrzysztofHerman KrzysztofHerman merged commit ddc3ea2 into IHP-GmbH:main Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants