Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICRC: Fix operations country scraping logic #2306

Merged
merged 1 commit into from
Nov 13, 2024
Merged

ICRC: Fix operations country scraping logic #2306

merged 1 commit into from
Nov 13, 2024

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Nov 13, 2024 •
edited
Loading

Addresses

Command

python manage.py ingest_icrc

Changes

  • hard code mapping for some country as the name doesnot match with name in db
  • Fix Operation country list and presence

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@szabozoltan69
Copy link
Contributor

Should we merge this? (The status is still Draft.)

@susilnem susilnem marked this pull request as ready for review November 13, 2024 12:17
@susilnem
Copy link
Member Author

@szabozoltan69
Let's merge this one and run the command.
python manage.py ingest_icrc

@szabozoltan69 szabozoltan69 merged commit 2b3f32f into develop Nov 13, 2024
3 checks passed
@szabozoltan69 szabozoltan69 deleted the fix/icrc-issue branch November 13, 2024 12:40
@szabozoltan69
Copy link
Contributor

Done:

~/go-api# python manage.py ingest_icrc
2024-11-13 12:57:35 INFO     Starting ICRC data ingest
2024-11-13 12:58:54 WARNING  instance does not have an es_id() method
...
2024-11-13 12:58:55 INFO     79 ICRC added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenav56 thenav56 thenav56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susilnem @szabozoltan69 @thenav56