You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For OpsLearning records there is a validation workflow process:
Data are not validated
Not validated data can be changed
Validation happens
Data are validated (and is_validated flag is true)
Validated data can be changed
If the is_validated field is false, we can suppose that the validation has not happened. For such records we should not allow to have ..._validated fields to be filled in (neither from Admin page, neither from API input), because otherwise it is difficult to define the moment, that "now" happened the validation, and we can populate the validated fields (based on not validated pairs) at that "save" moment: https://github.com/IFRCGo/go-api/blob/develop/per/models.py#L723
Or, if there is a nicer definition for the "save" moment when we can overwrite _validated fields with the non-validated pairs, it can be implemented. Until now we used all the fields to check that no data is in "validated" fields (at validation moment), but this way is not great if these fields can be filled up via API.
We should check if the API sending really requires to have some _validated fields also. If so, we should fix it.
The text was updated successfully, but these errors were encountered:
Issue
For OpsLearning records there is a validation workflow process:
If the is_validated field is false, we can suppose that the validation has not happened. For such records we should not allow to have ..._validated fields to be filled in (neither from Admin page, neither from API input), because otherwise it is difficult to define the moment, that "now" happened the validation, and we can populate the validated fields (based on not validated pairs) at that "save" moment: https://github.com/IFRCGo/go-api/blob/develop/per/models.py#L723
Or, if there is a nicer definition for the "save" moment when we can overwrite _validated fields with the non-validated pairs, it can be implemented. Until now we used all the fields to check that no data is in "validated" fields (at validation moment), but this way is not great if these fields can be filled up via API.
We should check if the API sending really requires to have some _validated fields also. If so, we should fix it.
The text was updated successfully, but these errors were encountered: