API typing issues

[udaynwa]

Review of typings issues in GO SERVER

• Looks like Appeal ID was changed from number to string. Is this correct?
  • /api/v2/appeal
• The filters for country and region change from number to number[]. Is this correct?
  • /api/v2/appeal
  • /api/v2/appeal/aggregated
• Models related to PER (area, rating counts, question, answer, etc.) have fields that are nullable/optional. Eg: title
  • /api/v2/per-formquestion
    • results[].question.component.area.title
  • /api/v2/per-assessment/{id}/
    • area_responses[].component_responses[].rating_details.title
    • area_responses[].component_responses[].area_details.title
  • /api/v2/per-formquestion
    • results[].component.area.title
    • results[].question

Review of typing issues in GO RISK SERVER

• hazard_type enum also has a string literal type ''
  • `/api/v1/country-seasonal/``
    • [].return_period_data.hazard_type
    • [].idmc[].hazard_type
    • [].inform_seasonal[].hazard_type
    • [].raster_displacement_data[].hazard_type
    • [].gwis_seasonal[].hazard_type
  • /api/v1/adam-exposure/
    • results[].hazard_type
  • /api/v1/pdc/
    • results[].hazard_type
  • /api/v1/meteoswiss/
    • results[].hazard_type
  • /api/v1/gdacs/
    • results[].hazard_type
  • /api/v1/seasonal/
    • [].idmc[].hazard_type
    • [].raster_displacement_data[].hazard_type
    • [].gwis_seasonal[].hazard_type
  • /api/v1/risk-score/
    • results[].hazard_type
• estimation_type enum also has a string literal type ''
  • /api/v1/country-seasonal/
    • [].ipc_displacement_data[].estimation_type