Add Registration Page #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshni73
force-pushed
the
feature/register-page
branch
from
be44b3b
to
35603d8
Compare
roshni73
force-pushed
the
feature/register-page
branch
from
35603d8
to
715b6d4
Compare
AdityaKhatri
requested changes
Oct 29, 2024
Comment on lines
+221
to
+189
| const loginInfo = resolveToComponent(strings.registerAccountPresent, { | ||
| loginLink: ( |
There was a problem hiding this comment.
why is this called loginInfo? Shouldn't it be registerInfo?
There was a problem hiding this comment.
because it contains information related to login, specifically a link to the login page.
AdityaKhatri
requested changes
Oct 29, 2024
AdityaKhatri
changed the base branch from
develop
to
project/phase-2-dummy-pages
roshni73
force-pushed
the
feature/register-page
branch
from
6d09c3c
to
09e9e0d
Compare
roshni73
force-pushed
the
feature/register-page
branch
from
09e9e0d
to
ed2ee4d
Compare
roshni73
force-pushed
the
feature/register-page
branch
from
c5eff62
to
4f10205
Compare
roshni73
force-pushed
the
feature/register-page
branch
from
4f10205
to
d32206b
Compare
roshni73
force-pushed
the
feature/register-page
branch
from
d32206b
to
01cbace
Compare
roshni73
force-pushed
the
feature/register-page
branch
from
01cbace
to
73a64aa
Compare
Remove unnecessary required fields
AdityaKhatri
force-pushed
the
feature/register-page
branch
from
73a64aa
to
8f84b58
Compare
AdityaKhatri
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.logmeant for debugging