Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): Fix focus mode jump to last selected issue #2093

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

nam-singh
Copy link
Contributor

  • Extension UI bug

This PR is related to the following issue(s):

Testing reference:

  • On selecting parent of last issue it should not jump back to last issue

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@nam-singh nam-singh self-assigned this Nov 13, 2024
@nam-singh
Copy link
Contributor Author

@tombrunet Noticed that the line if (path && path !== devtoolsState!.lastElementPath) was commented out in a previous PR. Without it, setSelectedElementPath is getting triggered multiple times, leading to unintended focus shifts. Re-enabling this line resolves the issue and stabilizes the focus behavior as expected. Please let me know if this caused any issues previously, and I'm happy to look into alternative solutions if needed. Thank you!

tombrunet
tombrunet previously approved these changes Nov 13, 2024
@tombrunet tombrunet dismissed their stale review November 13, 2024 16:58

Need to test more

@tombrunet
Copy link
Member

Not clear why that was originally commented out. Will try to do the various focus scenarios and see if anything crops up.

@tombrunet tombrunet merged commit 3c78d42 into master Nov 13, 2024
17 checks passed
@tombrunet tombrunet deleted the focusModeBug-2069-nam branch November 13, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG: Extension]: When clicking in the DOM while in 'focus mode', focus mode is jumping to last selected issue
2 participants