-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixrules(ARIA
region landmark rules): Improve consistency of failure messages
#1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calls out the use of baselines too Contributes to: /issues/1949 Signed-off-by: Adam Roberts <[email protected]>
fix(extension): Update Settings screenshots and text in User and Quick Guides for v7.3 support
fixrules(`meta_redirect_optional`, `aria_parent_required`, `aria_child_valid`): Map to WCAG and ACT rules to improve consistency
chore(engine): Create build archive script
Co-authored-by: Mike Gower <[email protected]>
1 task
fixrule(all rules): Rule help Requirement matches Requirement listing rule
fix(node): Add comments explaining value of the jest boilerplate
Updating rule server for 08.06.24
@tombrunet this PR is still looking odd, it now shows "merged" and no longer shows in the list of opened PR https://github.com/IBMa/equal-access/pulls. It also shows 232 changed files, of which none of these are part of the original scope of this PR and issue. So I'm going to create a new branch and a new PR for the ARIA landmark work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve consistency of failure messages for the following ARIA "landmark region" related rules:
This PR is related to the following issue(s):
Testing reference:
I have conducted the following for this PR: