Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(img_alt_valid) Reports "inapplicable" while ACT 23a2a8 expects "Failed" for Fail Example 2 #2090

Open
1 of 2 tasks
philljenkins opened this issue Nov 12, 2024 · 2 comments · May be fixed by #2108
Open
1 of 2 tasks
Assignees
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Nov 12, 2024

Checker rule img_alt_valid reports inconsistent with ACT rule(s) below (updated with 7 November results):

  • Failed examples should be failed by at least one of the Checker rules fail reason codes.
  • Checker should be mapping (report against) the same success criteria as what is expected by the ACT rule.
  1. Partially consistent with ACT rule: Image has non-empty accessible name 23a2a8:
    • Mapping: The Checker implementation correctly reports which success criteria ACT expects are failed by this rule: 1.1.1.
    • "inapplicable" Failed Example 2 is incorrectly reported by Checker rule img_alt_valid as "inapplicable", should be "failed".
    • opened this issue to resolve

Reference

Screenshot 2024-11-12 at 10 16 36 AM

@philljenkins philljenkins added ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component labels Nov 12, 2024
@philljenkins
Copy link
Contributor Author

philljenkins commented Nov 12, 2024

Failed Example 2 Open in a new tab

This element with role of img has an empty accessible name.

<div role="img" style="width:72px; height:48px; background-image: url(/test-assets/shared/w3c-logo.png)"></div>

Checker flags this div using a different rule, reason code, level, and mapping that doesn't report against this ACT rule rule: 23a2a8 :

  • Rule ID: aria_accessiblename_exists
  • Reason ID: fail_no_accessible_name
  • Recommendation, ACT will expect Violation [can we report Fail to ACT with Recommendation?]
  • Maps to 4.1.2, ACT will expect 1.1.1
  • Element <div> with "img" role has no accessible name Learn more
  • "Elements with certain roles should have accessible names"

@philljenkins
Copy link
Contributor Author

After discussion with Tom, an option is to add a new fail reason code to

  • Rule ID: aria_accessiblename_exists
  • new reason for something such as: "fail_no_accessible_name_img_role"
  • reasonCodes: ["fail_no_accessible_name_img_role"]
  • and map the new reason code to 1.1.1 (not 4.1.2 as rest of the rule)

See target_spacing_sufficient.ts as an example of separating the reasonCodes:

Screenshot 2024-11-12 at 2 19 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component
Projects
None yet
2 participants