From 464d47de876c922bcca78e1c3608b8b006ae9619 Mon Sep 17 00:00:00 2001
From: Shunguo Yan <shunguoy@us.ibm.com>
Date: Wed, 13 Nov 2024 13:01:45 -0600
Subject: [PATCH] fixrule(`aria_landmark_name_unique`): Change the accessible
 name length limitation (#2096)

* Testcase for aria_landmark_name_unique failure

* Check th existence of design pattern from the aria definition

* update the accessible name length

---------

Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
---
 accessibility-checker-engine/karma.conf.js    |   8 +-
 .../v4/rules/element_accesskey_labelled.ts    |   2 +-
 .../src/v4/util/AriaUtil.ts                   |   2 +-
 .../src/v4/util/CommonUtil.ts                 |   4 +-
 .../dcs-example.html                          | 128 ++++++++++++++++++
 .../FieldSet-hasarialabel.html                |  12 +-
 6 files changed, 142 insertions(+), 14 deletions(-)
 create mode 100644 accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/dcs-example.html

diff --git a/accessibility-checker-engine/karma.conf.js b/accessibility-checker-engine/karma.conf.js
index 9ba11327a..bdd3f1d96 100644
--- a/accessibility-checker-engine/karma.conf.js
+++ b/accessibility-checker-engine/karma.conf.js
@@ -47,12 +47,12 @@
                 //{ pattern: 'test/v2/checker/accessibility/rules/label_name_visible_ruleunit/label_offscreen.html', watched: true },
                 //{ pattern: 'test/v2/checker/accessibility/rules/aria_role_valid_ruleunit/td_attribute_invalid_copy.html', watched: true },
                 //{ pattern: 'test/v2/checker/accessibility/rules/text_block_heading_ruleunit/Headings-noneUsedEmphasizedText.html', watched: true },
-                { pattern: 'test/v2/checker/accessibility/rules/aria_parent_required_ruleunit/webComponentPass.html', watched: true },
-                { pattern: 'test/v2/checker/accessibility/rules/aria_parent_required_ruleunit/webComponentPass2.html', watched: true },
+                { pattern: 'test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/*.html', watched: true },
+                // { pattern: 'test/v2/checker/accessibility/rules/aria_parent_required_ruleunit/webComponentPass2.html', watched: true },
     
     
-                { pattern: 'test/**/*_ruleunit/*.html', watched: true },
-                { pattern: 'test/**/*_ruleunit/*.htm', watched: true },
+                // { pattern: 'test/**/*_ruleunit/*.html', watched: true },
+                // { pattern: 'test/**/*_ruleunit/*.htm', watched: true },
                 // all files ending in "_test"
                 // { pattern: 'test/*_test.js', watched: true },
                 { pattern: 'test/**/*_test.js', watched: true }
diff --git a/accessibility-checker-engine/src/v4/rules/element_accesskey_labelled.ts b/accessibility-checker-engine/src/v4/rules/element_accesskey_labelled.ts
index da43f16ae..0a2551355 100644
--- a/accessibility-checker-engine/src/v4/rules/element_accesskey_labelled.ts
+++ b/accessibility-checker-engine/src/v4/rules/element_accesskey_labelled.ts
@@ -64,7 +64,7 @@ export const element_accesskey_labelled: Rule = {
         if (!roles || roles.length === 0) return;
 
         let patterns = ARIADefinitions.designPatterns[roles[0]]
-        if (!patterns.nameFrom) 
+        if (!patterns || !patterns.nameFrom) 
             return;
 
         // ignore if accessble name is required (checked in other rules) or prohibited (text element)    
diff --git a/accessibility-checker-engine/src/v4/util/AriaUtil.ts b/accessibility-checker-engine/src/v4/util/AriaUtil.ts
index 6b5d0a90c..4823f40e1 100644
--- a/accessibility-checker-engine/src/v4/util/AriaUtil.ts
+++ b/accessibility-checker-engine/src/v4/util/AriaUtil.ts
@@ -768,7 +768,7 @@ export class AriaUtil {
         if (widget === null) {
             let ret = false;
             const role = AriaUtil.getResolvedRole(element); 
-            if (role && ARIADefinitions.designPatterns[role].roleType === 'widget')
+            if (role && ARIADefinitions.designPatterns[role] && ARIADefinitions.designPatterns[role].roleType === 'widget')
                 ret = true;
             
             CacheUtil.setCache(element.ownerDocument, "is_element_widget", ret);
diff --git a/accessibility-checker-engine/src/v4/util/CommonUtil.ts b/accessibility-checker-engine/src/v4/util/CommonUtil.ts
index ace859285..9b874819c 100644
--- a/accessibility-checker-engine/src/v4/util/CommonUtil.ts
+++ b/accessibility-checker-engine/src/v4/util/CommonUtil.ts
@@ -1646,8 +1646,8 @@ export class CommonUtil {
     }
 
     // truncate the given text to a given number of characters
-    // return truncated text
-    public static truncateText(text: string, len = 60) {
+    // return truncated text to 150 chars, same with the media_alt_brief rule
+    public static truncateText(text: string, len = 150) {
         if (!text) return text;
         text = text.trim();
         if (text.length > len)
diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/dcs-example.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/dcs-example.html
new file mode 100644
index 000000000..f384c69d6
--- /dev/null
+++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/aria_landmark_name_unique_ruleunit/dcs-example.html
@@ -0,0 +1,128 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+
+<!--
+   /******************************************************************************
+     Copyright:: 2020- IBM, Inc
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+  *****************************************************************************/
+-->
+
+<html lang="en">
+    <head>
+        <title>RPT Test Suite</title>
+    </head>
+
+    <body>
+        <main role="main">
+                <section
+                    role="region"
+                    aria-labelledby="twlp_sec_jca__adeappbind__title__1"
+                    id="twlp_sec_jca__adeappbind"
+                >
+                    <h2
+                        id="twlp_sec_jca__adeappbind__title__1"
+                    >
+                        Configuring authentication data and aliases with
+                        authData and a resource reference
+                    </h2>
+                </section>
+
+                <section
+                    role="region"
+                    aria-labelledby="twlp_sec_jca__cdade__title__1"
+                    id="twlp_sec_jca__cdade"
+                >
+                    <h2 id="twlp_sec_jca__cdade__title__1">
+                        Configuring authentication data and aliases with
+                        containerAuthData
+                    </h2>
+                </section>
+
+                <section
+                    role="region"
+                    aria-labelledby="twlp_sec_jca__adcadr__title__1"
+                    id="twlp_sec_jca__adcadr"
+                >
+                    <h2
+                        id="twlp_sec_jca__adcadr__title__1"
+                    >
+                        Configuring authentication data and aliases with
+                        authData and containerAuthDataRef
+                    </h2>
+                </section>
+        </main>
+        <script type="text/javascript">
+            UnitTest = {
+                ruleIds: ["aria_landmark_name_unique"],
+                results: [
+                {
+            "ruleId": "aria_landmark_name_unique",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/section[1]",
+              "aria": "/document[1]/main[1]/region[1]"
+            },
+            "reasonId": "Pass_0",
+            "message": "Multiple elements with \"region\" landmarks within the same parent region are distinguished by unique 'aria-label' or 'aria-labelledby'",
+            "messageArgs": [
+              "region"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_landmark_name_unique",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/section[2]",
+              "aria": "/document[1]/main[1]/region[2]"
+            },
+            "reasonId": "Pass_0",
+            "message": "Multiple elements with \"region\" landmarks within the same parent region are distinguished by unique 'aria-label' or 'aria-labelledby'",
+            "messageArgs": [
+              "region"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          },
+          {
+            "ruleId": "aria_landmark_name_unique",
+            "value": [
+              "INFORMATION",
+              "PASS"
+            ],
+            "path": {
+              "dom": "/html[1]/body[1]/main[1]/section[3]",
+              "aria": "/document[1]/main[1]/region[3]"
+            },
+            "reasonId": "Pass_0",
+            "message": "Multiple elements with \"region\" landmarks within the same parent region are distinguished by unique 'aria-label' or 'aria-labelledby'",
+            "messageArgs": [
+              "region"
+            ],
+            "apiArgs": [],
+            "category": "Accessibility"
+          }
+                ],
+            };
+            //]]>
+        </script>
+    </body>
+</html>
diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/fieldset_label_valid_ruleunit/FieldSet-hasarialabel.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/fieldset_label_valid_ruleunit/FieldSet-hasarialabel.html
index 2e950efd6..d1d2a0d08 100644
--- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/fieldset_label_valid_ruleunit/FieldSet-hasarialabel.html
+++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/fieldset_label_valid_ruleunit/FieldSet-hasarialabel.html
@@ -130,9 +130,9 @@ <h3>Input type Tests</h3>
               "aria": "/document[1]/form[2]/group[1]"
             },
             "reasonId": "Fail_2",
-            "message": "Group/Fieldset \"this is a potentially very long description of the fieldset...\" has a duplicate name to another group",
+            "message": "Group/Fieldset \"this is a potentially very long description of the fieldset and more description is possible\" has a duplicate name to another group",
             "messageArgs": [
-              "this is a potentially very long description of the fieldset..."
+              "this is a potentially very long description of the fieldset and more description is possible"
             ],
             "apiArgs": [],
             "category": "Accessibility"
@@ -148,9 +148,9 @@ <h3>Input type Tests</h3>
               "aria": "/document[1]/form[3]/group[1]"
             },
             "reasonId": "Fail_2",
-            "message": "Group/Fieldset \"this is a potentially very long description of the fieldset...\" has a duplicate name to another group",
+            "message": "Group/Fieldset \"this is a potentially very long description of the fieldset and more description is possible\" has a duplicate name to another group",
             "messageArgs": [
-              "this is a potentially very long description of the fieldset..."
+              "this is a potentially very long description of the fieldset and more description is possible"
             ],
             "apiArgs": [],
             "category": "Accessibility"
@@ -166,9 +166,9 @@ <h3>Input type Tests</h3>
               "aria": "/document[1]/form[4]/group[1]"
             },
             "reasonId": "Fail_2",
-            "message": "Group/Fieldset \"this is a potentially very long description of the fieldset...\" has a duplicate name to another group",
+            "message": "Group/Fieldset \"this is a potentially very long description of the fieldset and more description is possible\" has a duplicate name to another group",
             "messageArgs": [
-              "this is a potentially very long description of the fieldset..."
+              "this is a potentially very long description of the fieldset and more description is possible"
             ],
             "apiArgs": [],
             "category": "Accessibility"