Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] - Addition of volume data to the repository #7

Open
alexvalentine94 opened this issue Oct 31, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@alexvalentine94
Copy link
Collaborator

Proposal

Add the volumes of each of the cells in an input model to the repository.

Motivation

With MCNP this can be included on the SD card or otherwise set to one and used as a divisor in post-processing. In other codes, this has to be done in post-processing meaning that the list of volumes of the cells need to be stored somewhere.

Secondly, as this is a repository for benchmark inputs, its also makes sense to have some minimal validation of the inputs for the different codes. Comparing the volumes of the cells to the MCNP model is the most common approach. The computed volumes by stochastic methods could be stored alongside each benchmark.

Implementation

This could be included as metadata. Likely we don't want to make the existing metadata.json too busy but could consider volumes.json or .h5 containing the data for each code.

Effort is of course needed to perform the stochastic volume calculation for existing MCNP inputs but this should be performed in parallel with the development of inputs for alternative transport codes (as a validation step of the translation).

@alexvalentine94 alexvalentine94 added the enhancement New feature or request label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant