-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure core and ingest UI to use HCA auth0 #197
Comments
DCP DEMO on Tues 2018-12-04: Wranglers logging into in through UI to DCP auth. Only whitelisted users can access the system. Show that API is secured in the same way. |
Needs to be done imminently since warnings are appearing on @danielvaughan 's free account |
Per discussion with @aaclan-ebi this is not straightforward. We have been using the OAuth2.0 implicit grant up to now since ingest UI is a pure browser-side Angular app, and so can't be trusted with client_secret. However, it looks like DCP Auth requires use of OAuth 2.0 authorization code grant which gives out the client secret. Interestingly the demo code section in the DCP auth doc says that client_secret can be made available publicly. I find this surprising in light of the above. @Bento007 please could you explain how this works? [1] https://auth0.com/docs/api-auth/grant/implicit |
Regardless of grant we need to implement, @Bento007 could we request for a client id for the Ingest UI?
http://localhost:4200/callback |
We are currently managing auth0 using auth0-deploy-cli. You can modify the configuration here https://github.com/HumanCellAtlas/dcp-infra/tree/master/auth0 |
The client IDs and secrets are used to identify the application origin of the request. It not being used for secrecy. You should be able to use the https://auth.dev.data.humancellatlas.org/ to retrieve an access token for your webapp. |
Need a Google Service Account for DCP integration test to authenticate with ingest now. Going to ask for this in the tech arch meeting on 2019-01-03 |
Possible blocker is that dcp-diag may also need to update for change in the auth0 endpoint. I hear that you were going to look at this @sampierson? |
Yes @justincc , dcp-diag uses the same kind of Also if we are to switch Upload from connecting directly to RabbitMQ and use an API instead, Upload will need this code in future. |
The upload API endpoints are covered under upload-service#245. Can I create a similar ticket in dcp-diag so I don't lose track? |
Yes, please do. Thanks! |
UI changes or alternative covered in #285 |
Changes are pushed to production. https://github.com/HumanCellAtlas/ingest-kube-deployment/blob/master/production/changelog.md#29-january-2019 |
The text was updated successfully, but these errors were encountered: