Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force user to choose download directory #357

Open
DailyDreaming opened this issue Jun 7, 2019 · 4 comments
Open

Force user to choose download directory #357

DailyDreaming opened this issue Jun 7, 2019 · 4 comments
Labels
ENH orange Done by the Azul, Data Browser and Portal team

Comments

@DailyDreaming
Copy link
Contributor

If a user deletes their downloaded files they may be under the false impression that they've regained the disk space.

One possible solution is to add a new option that tells it whether to clean up or not.

@hannes-ucsc
Copy link
Contributor

hannes-ucsc commented Jun 12, 2019

My goal was always to allow successive invocations of the download functionality to reuse the file store. Also note that there are two possible implementation choices if we decided to delete the file store by default at program exit: always and on success only. The former would prohibit resumptions and is therefore unacceptable in my opinion. The latter would reintroduce the possibility of the file store to take up space without the user noticing.

One option not previously discussed is requiring the user to specify the download directory. The invariant would be that the file store is always a subdirectory of the download directory. If the specified download directory does not exist it would be created. This would signal more clearly to the user that they would need to delete that entire directory (which includes the file store) in order to "undo" the effect of a download.

@kozbo
Copy link
Collaborator

kozbo commented Jul 12, 2019

I prefer the option of requiring the user to specify the download directory. I think it would help to add a little documentation to this to tell users how to clean up.

@kozbo kozbo added the ENH label Jul 12, 2019
@hannes-ucsc
Copy link
Contributor

Let's go with those things two measures then, @kozbo.

I gave some additional reasoning here as well #394 (comment).

@hannes-ucsc hannes-ucsc added the orange Done by the Azul, Data Browser and Portal team label Aug 14, 2019
@theathorn theathorn added this to the Q4 2019 Milestone 2 milestone Oct 29, 2019
@theathorn
Copy link

Also see #397.

@theathorn theathorn modified the milestones: Q4 2019 Milestone 2, Q4 2019 Milestone 3 Nov 20, 2019
@theathorn theathorn changed the title Users may not be aware of the filestore's existence Force user to choose download directory Nov 20, 2019
@theathorn theathorn removed this from the Q4 2019 Milestone 3 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH orange Done by the Azul, Data Browser and Portal team
Projects
None yet
Development

No branches or pull requests

5 participants