Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues with notebooks completing execution #93

Open
chmreid opened this issue Dec 19, 2019 · 0 comments
Open

Fix multiple issues with notebooks completing execution #93

chmreid opened this issue Dec 19, 2019 · 0 comments
Assignees

Comments

@chmreid
Copy link
Collaborator

chmreid commented Dec 19, 2019

There are several notebooks that encounter exceptions or fail to complete execution. The easy solution is to simply ignore these notebooks during treon tests, but we should go back through each of these notebooks, uncover the problematic code, and fix it so that our users can successfully run the notebooks as well.

Specific examples:

  • in the "Login" notebook, there are several bash magic commands that (unnecessarily) try and actually run the hca login command, which fails, crashing the notebook
  • in the "Find cell counts" notebook, the elasticsearch query returns 0 results, crashing the notebook
  • several of the "download" notebooks (definitely 10x seq data nb) refer to non-existent resources or have queries that return 0 results
@chmreid chmreid added this to the Q4 2019 Milestone 3 milestone Dec 19, 2019
@chmreid chmreid self-assigned this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant