Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Typeahead should have an disabled prop #287

Closed
jackcmeyer opened this issue Feb 20, 2020 · 2 comments · Fixed by #290
Closed

Typeahead should have an disabled prop #287

jackcmeyer opened this issue Feb 20, 2020 · 2 comments · Fixed by #290
Assignees
@MatthewDorner
Labels
bug Something isn't working good first issue Good for newcomers in progress released
Milestone
v1.0.0

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Feb 20, 2020 •
edited
Loading

🐛 Bug Report

The typeahead component has no way of being set to disabled.

Expected behavior

There should be an disabled prop that controls whether or not the typeahead is disabed.

Technical Notes

https://www.npmjs.com/package/react-bootstrap-typeahead

Related Issues

#204
HospitalRun/hospitalrun#218
@jackcmeyer jackcmeyer added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 20, 2020
@jackcmeyer jackcmeyer added this to the v1.0.0 milestone Feb 20, 2020
@MatthewDorner
Copy link
Contributor

I can take this.

@jackcmeyer jackcmeyer added in progress and removed help wanted Extra attention is needed labels Feb 20, 2020
MatthewDorner added a commit to MatthewDorner/components that referenced this issue Feb 20, 2020
@MatthewDorner
fix(typeahead): add disabled prop to Typeahead
cf590b6 
HospitalRun#287
@MatthewDorner MatthewDorner mentioned this issue Feb 20, 2020
Merged
@jackcmeyer jackcmeyer changed the title Typeahead should have an isEditable prop Typeahead should have an disabled prop Feb 20, 2020
ghost pushed a commit that referenced this issue Feb 21, 2020
@semantic-release-bot
chore(release): 0.33.3 [skip ci]
f020df0 
## [0.33.3](v0.33.2...v0.33.3) (2020-02-21)

### Bug Fixes

* **typeahead:** add disabled prop to Typeahead ([cf590b6](cf590b6)), closes [#287](#287)
@ghost
Copy link

ghost commented Feb 21, 2020

🎉 This issue has been resolved in version 0.33.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewDorner MatthewDorner

Labels
bug Something isn't working good first issue Good for newcomers in progress released
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix(typeahead): add disabled prop to Typeahead MatthewDorner/components
2 participants
@jackcmeyer @MatthewDorner