Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复32位Java提示错误 #5129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

修复32位Java提示错误 #5129

wants to merge 3 commits into from

Conversation

Hill23333
Copy link

@Hill23333 Hill23333 commented Nov 16, 2024 •
edited
Loading

Fixes #5128

@Hill23333 Hill23333 mentioned this pull request Nov 16, 2024
Open
1 task
@Ad-closeNN
Copy link
Contributor

Ad-closeNN commented Nov 16, 2024 •
edited
Loading

感觉 IsWarn="True" 换成 IsWarn="False" 可能会更好？
删掉提示条可能会误下载到 32 位的 Java 导致还要再下一个?（虽然可能不大）

演示图片

image
image

Ad-closeNN/PCL2@c64c2ec...4018a9c
Ad-closeNN/PCL2@b6a52f9...c7a251d
https://github.com/Ad-closeNN/PCL2/actions/runs/11870991004

@3gf8jv4dv 3gf8jv4dv added · Bug 等待确认 已经过社区确认，等待开发者确认 labels Nov 16, 2024
@3gf8jv4dv
Copy link
Collaborator

修复 #5128 → Fixes #5128

@Hill23333
Copy link
Author

感觉 IsWarn="True" 换成 IsWarn="False" 可能会更好？ 删掉提示条可能会误下载到 32 位的 Java 导致还要再下一个?（虽然可能不大）

演示图片

image image

Ad-closeNN/[email protected] Ad-closeNN/[email protected] https://github.com/Ad-closeNN/PCL2/actions/runs/11870991004

我个人感觉这个提示给Warn会更合适一点（

@JingHai-Lingyun
Copy link
Collaborator

JingHai-Lingyun commented Nov 16, 2024 •
edited
Loading

可能需要一个新的状态，以实现 🟦Note，🟨Warning 和 🟥Caution 的三态提示……
蓝色提示效果轻了，红色又太重了……

@Hill23333
Copy link
Author

确实，Warn居然是红色...

@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 🟨 中 优先度：中 and removed 等待确认 已经过社区确认，等待开发者确认 labels Nov 17, 2024
@Hill23333
Copy link
Author

Hill23333 commented Nov 17, 2024 •
edited
Loading

关于给MyHint添加新的状态我觉得到时候开个新的pr就行，不用在这里了。
主要是因为如果改那么PCL2的帮助也得大改

@JingHai-Lingyun
Copy link
Collaborator

确实，向前兼容也是一件非常麻烦的事情……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LTCatt LTCatt Awaiting requested review from LTCatt

Assignees
No one assigned
Labels
· Bug 处理中 开发者正在调查或处理该项 🟨 中 优先度：中
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

未安装Java的情况下出现“32 位 Java 最多只能分配 1GB 内存，建议安装 64 位 Java！”
5 participants
@Hill23333 @Ad-closeNN @3gf8jv4dv @JingHai-Lingyun @LTCatt