-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wallet to a hat #10
Comments
This may be unsafe. Consider the following example:
If Account A wears Hat 1, then it can -- acting as the oracle for Hat 2 -- sever the tie between Hat 2 and its oracle (Account B). This creates a risk for Charlize's staked tokens: has Charlize lost them when her Hat's no longer has an oracle? It depends on the code governing her staking, so she may be ok, but perhaps not. To fully protect herself, Charlize would need to understand who controls all the logic that impact her staked tokens. If we don't give hats wallets, Charlize just needs to understand her hat's oracle contract. But if we give hats wallets, the number of contracts Charlize needs to understand (or trust) increases from 1 to multiple. It's 2 in the above example, but there could feasibly be a long string of wallets controlled by hats wearing other hats. This risk exists primarily for oracles, but it also creates some issues with conditions. |
also related to #7 |
As discussed recently, attaching a wallet (i.e. a proxy contract) to an NFT may best be implemented as a protocol of its own, such as... |
Update Solady dependency
Potentially deploy a proxy contract attached to each hat. This would...
The text was updated successfully, but these errors were encountered: