Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept "file:line:col" argument format #68

Open
diversys opened this issue Mar 2, 2021 · 3 comments · May be fixed by #91
Open

Accept "file:line:col" argument format #68

diversys opened this issue Mar 2, 2021 · 3 comments · May be fixed by #91
Labels
enhancement

Comments

@diversys
Copy link
Member

diversys commented Mar 2, 2021 •
edited
Loading

Many tools like g++, grep, etc. print file locations as file:line:col, for example configure:89:15.

Many editors like QtCreator, Geany, or CLion understand this format, and open the file with the text cursor ready to go at the desired location.

In a nutshell, it should be able to lpe configure:89:15.
fritzvd pushed a commit to fritzvd/Pe that referenced this issue Jul 27, 2021
change statusbar to show file:col:line fix HaikuArchives#68
deeeff2
@fritzvd fritzvd mentioned this issue Jul 27, 2021
Closed
OscarL added a commit to OscarL/Pe that referenced this issue Mar 5, 2024
@OscarL
Implement lpe file:line:col
ed240dc 
Fixes HaikuArchives#68.
@OscarL OscarL linked a pull request Mar 5, 2024 that will close this issue
Open
@OscarL
Copy link
Contributor

OscarL commented Mar 5, 2024

Hey there @diversys! Did my best (yeah... doesn't amounts to much :-D), and got something that seems to work on my tests.

If you find the time, would be nice to know if #91 works well enough for you. Thanks in advance.

@OscarL
Copy link
Contributor

OscarL commented Mar 6, 2024

Ok, I see that /bin/open uses a B_REFS_RECEIVED BMessage with two fields: be:line and be:column.

I need to make sure Pe also accepts that (not only my first attempt with lpe as in #91), as it is what Terminal uses, after all.

Will let you know when I have something I'm happier with.

OscarL added a commit to OscarL/Pe that referenced this issue Mar 6, 2024
@OscarL
Implement lpe file:line:col and /bin/open file:line:col.
f473584 
The latter is what Terminal uses when "hyperlinking" to filenames.

Fixes HaikuArchives#68.
@OscarL
Copy link
Contributor

OscarL commented Mar 6, 2024

Ok, that took less time than what I expected. PR ready for review/testing.

OscarL added a commit to OscarL/Pe that referenced this issue Mar 16, 2024
@OscarL
Implement lpe file:line:col and /bin/open file:line:col.
4a2f0a3 
The latter is what Terminal uses when "hyperlinking" to filenames.

Fixes HaikuArchives#68.
OscarL added a commit to OscarL/Pe that referenced this issue Mar 16, 2024
@OscarL
Implement lpe file:line:col and /bin/open file:line:col.
20c13a9 
The latter is what Terminal uses when "hyperlinking" to filenames.

Fixes HaikuArchives#68.
OscarL added a commit to OscarL/Pe that referenced this issue Nov 18, 2024
@OscarL
Support opening files with file:line:col style arguments.
a0b4a80 
(support for ":col" is what's new)

lpe uses a custom message, while `/bin/open file:line:col` (what Terminal uses when
"hyperlinking" to filenames, for example) uses a B_REFS_RECEIVED message.

We support both.

Fixes HaikuArchives#68.
OscarL added a commit to OscarL/Pe that referenced this issue Nov 18, 2024
@OscarL
Support opening files with file:line:col style arguments.
fcb94e4 
(support for ":col" is what's new)

lpe uses a custom message, while `/bin/open file:line:col` (what Terminal uses when
"hyperlinking" to filenames, for example) uses a B_REFS_RECEIVED message.

We support both.

Fixes HaikuArchives#68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support opening files with file:line:col style arguments. OscarL/Pe
2 participants
@OscarL @diversys