Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong position for move action #374

Open
sakura-sukii opened this issue Oct 20, 2024 · 3 comments
Open

Wrong position for move action #374

sakura-sukii opened this issue Oct 20, 2024 · 3 comments
Assignees
Labels

Comments

@sakura-sukii
Copy link

I'm trying to use gumtree for finding some move action, the test files I use can found here: jina-ai/clip-as-service@eafb30f the python file: server/bert_serving/server/init.py.
diff file.zip

I run the command to get the diff output by gumtree, while in the ''move-tree'' action as follow:

move-tree

suite [15665,17061]
funcdef [15678,16454]
name: build_job [15682,15691]
parameters [15691,15699]
param [15692,15698]
name: socket [15692,15698]
suite [15700,16454]
simple_stmt [15717,15762]
expr_stmt [15717,15761]
testlist_star_expr [15717,15735]
name: client_id [15717,15726]
operator: , [15726,15727]
name: raw_msg [15728,15735]
operator: = [15736,15737]
atom_expr [15738,15761]
name: socket [15738,15744]
trailer [15744,15759]
name: recv_multipart [15745,15759]
trailer [15759,15761]
simple_stmt [15778,15807]
expr_stmt [15778,15806]
name: msg [15778,15781]
operator: = [15782,15783]
atom_expr [15784,15806]
name: jsonapi [15784,15791]
trailer [15791,15797]
name: loads [15792,15797]
trailer [15797,15806]
name: raw_msg [15798,15805]
simple_stmt [15823,15897]
atom_expr [15823,15896]
name: self [15823,15827]
trailer [15827,15834]
name: logger [15828,15834]
trailer [15834,15839]
name: info [15835,15839]
trailer [15839,15896]
term [15840,15895]
string: 'new job\tsize: %d\tclient: %s' [15840,15871]
operator: % [15872,15873]
atom [15874,15895]
testlist_comp [15875,15894]
atom_expr [15875,15883]
name: len [15875,15878]
trailer [15878,15883]
name: msg [15879,15882]
operator: , [15883,15884]
name: client_id [15885,15894]
simple_stmt [16010,16065]
expr_stmt [16010,16064]
name: is_tokenized [16010,16022]
operator: = [16023,16024]
atom_expr [16025,16064]
name: all [16025,16028]
trailer [16028,16064]
argument [16029,16063]
atom_expr [16029,16049]
name: isinstance [16029,16039]
trailer [16039,16049]
arglist [16040,16048]
name: el [16040,16042]
operator: , [16042,16043]
name: list [16044,16048]
sync_comp_for [16050,16063]
name: el [16054,16056]
name: msg [16060,16063]
simple_stmt [16081,16167]
expr_stmt [16081,16166]
name: tmp_f [16081,16086]
operator: = [16087,16088]
atom_expr [16089,16166]
name: list [16089,16093]
trailer [16093,16166]
atom_expr [16094,16165]
name: convert_lst_to_features [16094,16117]
trailer [16117,16165]
arglist [16118,16164]
name: msg [16118,16121]
operator: , [16121,16122]
atom_expr [16123,16139]
name: self [16123,16127]
trailer [16127,16139]
name: max_seq_len [16128,16139]
operator: , [16139,16140]
name: tokenizer [16141,16150]
operator: , [16150,16151]
name: is_tokenized [16152,16164]
simple_stmt [16183,16454]
return_stmt [16183,16453]
atom [16190,16453]
operator: { [16190,16191]
dictorsetmaker [16212,16435]
string: 'client_id' [16212,16223]
name: client_id [16225,16234]
operator: , [16234,16235]
string: 'input_ids' [16256,16267]
atom [16269,16297]
testlist_comp [16270,16296]
atom_expr [16270,16281]
name: f [16270,16271]
trailer [16271,16281]
name: input_ids [16272,16281]
sync_comp_for [16282,16296]
name: f [16286,16287]
name: tmp_f [16291,16296]
operator: , [16297,16298]
string: 'input_mask' [16319,16331]
atom [16333,16362]
testlist_comp [16334,16361]
atom_expr [16334,16346]
name: f [16334,16335]
trailer [16335,16346]
name: input_mask [16336,16346]
sync_comp_for [16347,16361]
name: f [16351,16352]
name: tmp_f [16356,16361]
operator: , [16362,16363]
string: 'input_type_ids' [16384,16400]
atom [16402,16435]
testlist_comp [16403,16434]
atom_expr [16403,16419]
name: f [16403,16404]
trailer [16404,16419]
name: input_type_ids [16405,16419]
sync_comp_for [16420,16434]
name: f [16424,16425]
name: tmp_f [16429,16434]
operator: } [16452,16453]
simple_stmt [16467,16547]
expr_stmt [16467,16546]
name: tokenizer [16467,16476]
operator: = [16477,16478]
atom_expr [16479,16546]
name: FullTokenizer [16479,16492]
trailer [16492,16546]
argument [16493,16545]
name: vocab_file [16493,16503]
operator: = [16503,16504]
atom_expr [16504,16545]
name: os [16504,16506]
trailer [16506,16511]
name: path [16507,16511]
trailer [16511,16516]
name: join [16512,16516]
trailer [16516,16545]
arglist [16517,16544]
atom_expr [16517,16531]
name: self [16517,16521]
trailer [16521,16531]
name: model_dir [16522,16531]
operator: , [16531,16532]
string: 'vocab.txt' [16533,16544]
simple_stmt [16559,16581]
expr_stmt [16559,16580]
name: poller [16559,16565]
operator: = [16566,16567]
atom_expr [16568,16580]
name: zmq [16568,16571]
trailer [16571,16578]
name: Poller [16572,16578]
trailer [16578,16580]
simple_stmt [16593,16627]
atom_expr [16593,16626]
name: poller [16593,16599]
trailer [16599,16608]
name: register [16600,16608]
trailer [16608,16626]
arglist [16609,16625]
name: sock [16609,16613]
operator: , [16613,16614]
atom_expr [16615,16625]
name: zmq [16615,16618]
trailer [16618,16625]
name: POLLIN [16619,16625]
simple_stmt [16639,16679]
atom_expr [16639,16678]
name: poller [16639,16645]
trailer [16645,16654]
name: register [16646,16654]
trailer [16654,16678]
arglist [16655,16677]
name: sock_hprio [16655,16665]
operator: , [16665,16666]
atom_expr [16667,16677]
name: zmq [16667,16670]
trailer [16670,16677]
name: POLLIN [16671,16677]
simple_stmt [16692,16733]
atom_expr [16692,16732]
name: self [16692,16696]
trailer [16696,16703]
name: logger [16697,16703]
trailer [16703,16708]
name: info [16704,16708]
trailer [16708,16732]
string: 'ready and listening!' [16709,16731]
while_stmt [16746,17061]
not_test [16752,16779]
atom_expr [16756,16779]
name: self [16756,16760]
trailer [16760,16770]
name: exit_flag [16761,16770]
trailer [16770,16777]
name: is_set [16771,16777]
trailer [16777,16779]
suite [16780,17061]
simple_stmt [16797,16826]
expr_stmt [16797,16825]
name: events [16797,16803]
operator: = [16804,16805]
atom_expr [16806,16825]
name: dict [16806,16810]
trailer [16810,16825]
atom_expr [16811,16824]
name: poller [16811,16817]
trailer [16817,16822]
name: poll [16818,16822]
trailer [16822,16824]
if_stmt [16842,16984]
comparison [16845,16865]
name: sock_hprio [16845,16855]
name: events [16859,16865]
suite [16866,16984]
simple_stmt [16887,16936]
atom_expr [16887,16935]
name: self [16887,16891]
trailer [16891,16898]
name: logger [16892,16898]
trailer [16898,16903]
name: info [16899,16903]
trailer [16903,16935]
string: 'a high priority job received' [16904,16934]
simple_stmt [16956,16984]
yield_expr [16956,16983]
atom_expr [16962,16983]
name: build_job [16962,16971]
trailer [16971,16983]
name: sock_hprio [16972,16982]
if_stmt [17000,17061]
comparison [17003,17017]
name: sock [17003,17007]
name: events [17011,17017]
suite [17018,17061]
simple_stmt [17039,17061]
yield_expr [17039,17060]
atom_expr [17045,17060]
name: build_job [17045,17054]
trailer [17054,17060]
name: sock [17055,17059]
to
funcdef [15678,16454]
at 2

The new location seems not to be the right location in the file after change, but the location in the file before change. BUT, when I try several other cases, some time it links to the 'after' file, some time the 'before' file. In general, it "SHOULD" link to the new position in 'after' file.

@sakura-sukii
Copy link
Author

@jrfaller

@jrfaller jrfaller self-assigned this Oct 21, 2024
@jrfaller jrfaller added the bug label Oct 21, 2024
@jrfaller
Copy link
Member

Do you think it could be related to #334 ?

@sakura-sukii
Copy link
Author

sakura-sukii commented Oct 21, 2024

Yes, thank you for offer the related issue, and I try the command of JSON and got the right position. I use the API command in the wiki and got the wrong position, so I wonder to know how can I get the destination position of 'move' action and 'insert' action use API? I noticed that you reply herehttps://github.com/GumTreeDiff/gumtree/issues/334#issuecomment-1943332178 also mentioned the class that API linked to., but I used that and gain a position linked to the source file, not the destination file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants