Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "secondary" color option #38

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Add "secondary" color option #38

merged 3 commits into from
Jun 12, 2023

Conversation

an-prata
Copy link
Contributor

Adds a "secondary" color option similar to "auto" to specify the second highest weighted color of the album artwork. "secondary" is implemented in largely the same way as "auto".

Apologies in advance if this feature was omitted intentionally.

@GuardKenzie
Copy link
Owner

Thanks for this pull request; everything looks good! I'll take a better look and hopefully merge this next week/weekend. 🧡

Since this overwrites another curses colour pair, I'll also add a note in the README that makes users of terminals that don't reset properly aware of that (see #34).

@an-prata
Copy link
Contributor Author

Have you decided not to merge this because of the plans for v2? Asking since its been a while. I know v2 would eventually just overwrite this pr but for the meantime it may be nice to have the feature. I've been using my fork on my desktop for a while and it would be nice to get back to using the AUR package.

@GuardKenzie
Copy link
Owner

Sorry for the late reply! I was hesitant to merge this because it would exasperate #34, however, since I'm working on v2 which will (hopefully) resolve that I'll go ahead and merge.

@GuardKenzie GuardKenzie merged commit bed2c58 into GuardKenzie:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants