Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint - switch to Google style guide #465

Open
askmeegs opened this issue Mar 8, 2021 · 6 comments
Open

Pylint - switch to Google style guide #465

askmeegs opened this issue Mar 8, 2021 · 6 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. python Pull requests that update Python code type: cleanup An internal cleanup or hygiene concern.
Milestone

Comments

@askmeegs
Copy link
Collaborator

askmeegs commented Mar 8, 2021

Current we have a pylint file - https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/master/.pylintrc - that ignores certain pylint errors in the Python service source code.

Let's try to remove most of these ignores to get the most out of linting, using Google's python style guide as source material for what messages might be okay to ignore.

@askmeegs askmeegs added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. python Pull requests that update Python code labels Mar 8, 2021
@askmeegs askmeegs added this to the 🏦 Q2 2021 milestone Mar 23, 2021
@bourgeoisor
Copy link
Member

This is still planned in the long term.

@bourgeoisor
Copy link
Member

Still want to do this.
@glasnt also suggested considering black as an alternative to pylint.

@glasnt
Copy link
Collaborator

glasnt commented Sep 8, 2022

python-docs-samples uses flake8 (to conform to the styleguide) and black is optional (docs). The flake8 config in noxfile.py should be useful here.

@parthea
Copy link

parthea commented Feb 2, 2023

pyink is a fork of black under the Google org and may be an alternate to black
https://github.com/google/pyink

@parthea
Copy link

parthea commented Feb 2, 2023

isort tool can also be used to sort imports https://github.com/PyCQA/isort

@minherz
Copy link

minherz commented Jul 27, 2023

The work on this item is postponed to Q4'24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. python Pull requests that update Python code type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

5 participants