Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Window interface #189

Open
hhirsch opened this issue Mar 3, 2019 · 0 comments
Open

Clean up Window interface #189

hhirsch opened this issue Mar 3, 2019 · 0 comments
Labels

Comments

@hhirsch
Copy link
Member

hhirsch commented Mar 3, 2019

The Window class is messy to use.

  • When you use it without running setConfig you'll do method calls on nullptrs leading to segfaults
  • There is input code crammed in there

We want the following changes:

  • Erase dependency to the Config class altogether using reasonable defaults, setters and an intermediate (named WindowConfigurator) class that applies config values to setters of the Window class.
  • Move the input handling stuff to a different class
  • Dramatically decrease LOC in Window class
  • Move main functions to source/core/gl
  • Possibly move into own repository
@hhirsch hhirsch added the EPIC label Mar 3, 2019
@hhirsch hhirsch assigned hhirsch and unassigned hhirsch Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant