Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo DB Error Handling #2492

Open
MoeNick opened this issue Aug 23, 2021 · 5 comments
Open

Mongo DB Error Handling #2492

MoeNick opened this issue Aug 23, 2021 · 5 comments
Assignees

Comments

@MoeNick
Copy link
Member

MoeNick commented Aug 23, 2021

According to Reza pen test, our data structure may expose on wrong requests. So we have to provide proper error handling for it.

@mohammadranjbarz
Copy link
Collaborator

example error:
MongoDbError.JPG

@mohammadranjbarz
Copy link
Collaborator

Can reproduce like this:
calling this URL in postman:
wss://feathers.develop.giveth.io/socket.io/?EIO=3&transport=websocket
with this message data:

4221["campaigns::find",{"$ne":{"status":"hi"}}]

mohammadranjbarz added a commit to Giveth/feathers-giveth that referenced this issue Aug 31, 2021
mohammadranjbarz added a commit to Giveth/feathers-giveth that referenced this issue Aug 31, 2021
@mohammadranjbarz
Copy link
Collaborator

Before deploy on UAT
Screen Shot 1400-06-10 at 12.29.04.png

After deploy
Screen Shot 1400-06-10 at 13.07.23.png

@rezagazmeh
Copy link
Collaborator

rezagazmeh commented Sep 8, 2021

@MoeNick
@mohammadranjbarz
Database error not detected. But Server Stack trace returned to client.
Error handling on the server side must also be done.
A new user story definition is suggested for the server side error handling.

@mohammadranjbarz
Copy link
Collaborator

@MoeNick
@mohammadranjbarz
Database error not detected. But Server Stack trace returned to client.
Error handling on the server side must also be done.
A new user story definition is suggested for the server side error handling.

I added Giveth/feathers-giveth#612 for what @rezagazmeh said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants