Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pendingAmountRemaining field is not cleaned after donation is committed #432

Open
aminlatifi opened this issue Mar 27, 2021 · 6 comments
Open
Assignees
Labels
bug can't reproduce We are unable to reproduce the described behaviour.

Comments

@aminlatifi
Copy link
Member

Giveth/giveth-dapp#1950 is reported due to not cleaning pendingAmountRemaining of donations. This field is not deleted from donation entity sometimes and remains till simulation script cleanup.

@mohammadranjbarz
Copy link
Collaborator

@MoeNick
I couldn't reproduce this, and with reading code I couldn't find a clue to see what happened

@mohammadranjbarz mohammadranjbarz added the can't reproduce We are unable to reproduce the described behaviour. label May 10, 2021
@MoeNick
Copy link
Member

MoeNick commented May 10, 2021

@aminlatifi do have any clue?

@mohammadranjbarz mohammadranjbarz removed the can't reproduce We are unable to reproduce the described behaviour. label May 10, 2021
@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented May 10, 2021

@MoeNick
Amin gave me some idea, I'm working on it

@mohammadranjbarz
Copy link
Collaborator

I think it's not a problem, after investigating I knew that some Waiting and Committed donations may have pendingAmountRemaining, you can check this document:
Giveth/giveth-beta-docs#7

and I think the root cause of this issue was problem in handling some events, I think we can close this issue because it's nothing to do for this issue
@aminlatifi @MoeNick

@MoeNick
Copy link
Member

MoeNick commented May 12, 2021

I think it's not a problem, after investigating I knew that some Waiting and Committed donations may have pendingAmountRemaining, you can check this document:
Giveth/giveth-beta-docs#7

and I think the root cause of this issue was problem in handling some events, I think we can close this issue because it's nothing to do for this issue
@aminlatifi @MoeNick

"Handling some events" means we needs to do smth? Is the problem is going to be solved by closing this issue? Or it should just rename?

@mohammadranjbarz
Copy link
Collaborator

I think it's not a problem, after investigating I knew that some Waiting and Committed donations may have pendingAmountRemaining, you can check this document:
Giveth/giveth-beta-docs#7
and I think the root cause of this issue was problem in handling some events, I think we can close this issue because it's nothing to do for this issue
@aminlatifi @MoeNick

"Handling some events" means we needs to do smth? Is the problem is going to be solved by closing this issue? Or it should just rename?

I think maybe #435 resolve this issue,
the old queue had problems and some events got stuck on that,
the new queue is on UAT server, I think deploying that maybe solve this type of issues

@mohammadranjbarz mohammadranjbarz added the can't reproduce We are unable to reproduce the described behaviour. label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug can't reproduce We are unable to reproduce the described behaviour.
Projects
None yet
Development

No branches or pull requests

3 participants