Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOG_STDOUT support #14

Open
mhmdksh opened this issue May 16, 2023 · 2 comments
Open

Add LOG_STDOUT support #14

mhmdksh opened this issue May 16, 2023 · 2 comments
Assignees

Comments

@mhmdksh
Copy link
Collaborator

mhmdksh commented May 16, 2023

This is meant to lessen the development burden to support Elastic Logging natively by the application or any direct centralized logging solution

Take into consideration the below:

  • Logs are written to STDOUT & STDERR instead of a file
  • This should be optional (We are only using this on demand, and specific use case, ex: Kubernetes for centralised logging)
  • The application should not crash in case there is no .log file and this option is enabled (We should not create a volume in k8s to hold the .log file just for the application to start successfully)

Check this for reference: Giveth/impact-graph@0f06e0a

@aminlatifi
Copy link
Member

This is meant to lessen the development burden to support Elastic Logging natively by the application or any direct centralized logging solution

Take into consideration the below:

  • Logs are written to STDOUT & STDERR instead of a file
  • This should be optional (We are only using this on demand, and specific use case, ex: Kubernetes for centralised logging)
  • The application should not crash in case there is no .log file and this option is enabled (We should not create a volume in k8s to hold the .log file just for the application to start successfully)

Check this for reference: Giveth/impact-graph@0f06e0a

Thanks @mhmdksh,
Though, the modification by Giveth/impact-graph@0f06e0a doesn't stop writing files to a directory! You mean we must disable it too?

@mhmdksh
Copy link
Collaborator Author

mhmdksh commented May 24, 2023

Hey @aminlatifi

So this is the point that I was not sure about. But after reviewing it for a little bit I guess we can leave it as it is. (I mean no change to logging to a .log file is required)

Instead, I should modify the docker attached volumes in the kubernetes deployment in order for it not to make mapping a log file necessary. And see how it goes.

So I assume we can proceed forward with the other STDOUT & STDERR logging option normally.

@mhmdksh mhmdksh assigned aminlatifi and MoeNick and unassigned aminlatifi Jun 5, 2023
aminlatifi added a commit that referenced this issue Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants