Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Update deviceToken to empty once unregister void notifications #608

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[Fix]Update deviceToken to empty once unregister void notifications #608

merged 2 commits into from
Nov 29, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Nov 27, 2024 •
edited
Loading

📝 Summary

Provide a consistent mechanism for consumers of CallKitAdapter to remove devices for a user account.

Docs update PR: here

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Nov 27, 2024
@ipavlidakis ipavlidakis self-assigned this Nov 27, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner November 27, 2024 11:11
@ipavlidakis ipavlidakis force-pushed the fix/empy-voip-notification-token-on-unregister branch from 9b631f8 to 7d2ec3b Compare November 27, 2024 11:11
martinmitrevski
martinmitrevski reviewed Nov 27, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 27, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.61 MB 7.61 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the fix/empy-voip-notification-token-on-unregister branch from d169a72 to 6a8cb18 Compare November 27, 2024 11:21
@ipavlidakis ipavlidakis merged commit d3dc7cc into develop Nov 29, 2024
5 checks passed
@ipavlidakis ipavlidakis deleted the fix/empy-voip-notification-token-on-unregister branch November 29, 2024 13:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
126 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski