Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounding.py is excluded from github actions #72

Open
TolisChal opened this issue Aug 5, 2023 · 5 comments · Fixed by #92
Open

rounding.py is excluded from github actions #72

TolisChal opened this issue Aug 5, 2023 · 5 comments · Fixed by #92
Labels

Comments

@TolisChal
Copy link
Member

The test file sampling.py is not included in the github actions.
However, when I added it fails.

@vfisikop vfisikop added the tests label Mar 1, 2024
@vfisikop vfisikop changed the title sampling.py is excluded from github actions rounding.py is excluded from github actions Mar 28, 2024
@vfisikop
Copy link
Contributor

sampling.py is included in github actions and runs correctly but rounding.py is not included and it fails if added.

@vfisikop
Copy link
Contributor

I reopen it since we have to find a way to run gurobi based tests on CI.

@vfisikop vfisikop reopened this Mar 28, 2024
@hariszaf
Copy link
Collaborator

This is possible but we will have to update or extend the license from time to time.
What we need is a Web License Service

@vissarion
Copy link
Member

Also there is non gurobi rounding version. And this exposes a deeper issue: the slow_* and fast_* function design where there is a lot of duplicate code and they are difficult to maintain or extend. This could be (partially) fixed by designing a more generic interface to lp solvers (see #84).

@hariszaf
Copy link
Collaborator

Then it's maybe better instead of going through the WLS task, to work on the #84 so we move to optlang

"Optlang provides a common interface to a series of optimization tools, so different solver backends can be changed in a transparent way."

so we do not care of maintaining more than one implementations for the same task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants